Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update secret retrieval for onepassword #41

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Update secret retrieval for onepassword #41

merged 2 commits into from
Dec 23, 2023

Conversation

naswierczek
Copy link
Contributor

  • retrieve json data from onepassword for secret & field extract value from json data

bluelabsbutler
bluelabsbutler reviewed Dec 23, 2023
View reviewed changes
tests/test_lpass.py Outdated
def test_lpass_field_notes_raises(self):
with self.assertRaises(NotImplementedError):
lpass.lpass_field('my_name', 'notes')
@patch('db_facts.lpass.check_output', side_effect=CalledProcessError(1,"mocked_op"))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[flake8] E231 missing whitespace after ','

@naswierczek
Fix 1password secret retrieval
490292c 
- updates lpass_field() internals to properly extract a secret
  note from 1password CLI
- Updated test mocks
- Updated requirements.txt to add dependencies that were missing
@naswierczek naswierczek force-pushed the fix-lpass-to-read-1pass-notes branch from 1586632 to 490292c Compare December 23, 2023 16:15
@naswierczek naswierczek marked this pull request as ready for review December 23, 2023 16:15
@naswierczek naswierczek requested a review from Brunope December 23, 2023 16:15
@naswierczek
Copy link
Contributor Author

@Brunope This should be ready for review and merge

@Brunope Brunope merged commit 0c65b5d into master Dec 23, 2023
5 checks passed
@Brunope Brunope deleted the fix-lpass-to-read-1pass-notes branch December 23, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluelabsbutler bluelabsbutler bluelabsbutler left review comments

@Brunope Brunope Brunope approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naswierczek @Brunope @bluelabsbutler