Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the use of secrets-manager as a backend, like lastpass #28

Merged
merged 4 commits into from
Sep 19, 2022
Merged

Enable the use of secrets-manager as a backend, like lastpass #28

merged 4 commits into from
Sep 19, 2022

Conversation

austinweisgrau
Copy link
Contributor

No description provided.

@austinweisgrau
Copy link
Contributor Author

Following the convention that exists between db-facts and lastpass, db-facts expects that database credentials are stored with these (case-insensitive) keys: hostname, username, port, database, password and optionally type

I think the lastpass credentials keys are expected to be title-cased but I made it case-insensitive for secrets_manager

@ryantimjohn
Copy link
Contributor

ryantimjohn commented Sep 16, 2022 •
edited
Loading

WTF... the CI tests are failing on code checkout?

@ryantimjohn
Copy link
Contributor

@hilary-b sorry to tap you in, but the CircleCI tests are failing in what seems to be a misconfigured Git Checkout? Seems that the deploy key has expired or was just never configured on the GH side. I'm going to fill that in, per this: https://circleci.com/docs/github-integration#enable-your-project-to-check-out-additional-private-repositories

please let me know if I'm doing something silly

bluelabsbutler
bluelabsbutler reviewed Sep 16, 2022
View reviewed changes
db_facts/db_info.py Outdated Show resolved Hide resolved
bluelabsbutler
bluelabsbutler reviewed Sep 16, 2022
View reviewed changes
db_facts/db_info.py Outdated Show resolved Hide resolved
@ryantimjohn
Copy link
Contributor

Okie... that did the trick. It's not able to checkout. But it fails on build because of a missing... rust compiler. Wut?

jessezlotoff
jessezlotoff reviewed Sep 19, 2022
View reviewed changes
db_facts/aws_secrets_manager.py Outdated Show resolved Hide resolved
tests/test_secrets_manager.py Show resolved Hide resolved
@austinweisgrau austinweisgrau force-pushed the secrets_manager branch 4 times, most recently from 2f1fa28 to 1c10fa0 Compare September 19, 2022 17:17
ryantimjohn
ryantimjohn approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@ryantimjohn ryantimjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @austinweisgrau!

@austinweisgrau austinweisgrau mentioned this pull request Sep 19, 2022
Merged
@austinweisgrau austinweisgrau merged commit 249ee59 into master Sep 19, 2022
@austinweisgrau austinweisgrau deleted the secrets_manager branch September 19, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluelabsbutler bluelabsbutler bluelabsbutler left review comments

@ryantimjohn ryantimjohn ryantimjohn approved these changes

@jessezlotoff jessezlotoff jessezlotoff approved these changes

@hilary-b hilary-b Awaiting requested review from hilary-b

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@austinweisgrau @ryantimjohn @bluelabsbutler @jessezlotoff