Explicit deinitialization of progress listeners.

This addresses a memory leak with Microsoft Edge. Thanks @butonic for the report, investigation and fix. Closes #3508
blueimp · Oct 14, 2018 · 3dd18f9 · 3dd18f9
1 parent e368706
commit 3dd18f9
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/js/jquery.fileupload.js b/js/jquery.fileupload.js
@@ -434,6 +434,13 @@
             }
         },
 
+        _deinitProgressListener: function (options) {
+            var xhr = options.xhr ? options.xhr() : $.ajaxSettings.xhr();
+            if (xhr.upload) {
+                $(xhr.upload).unbind('progress');
+            }
+        },
+
         _isInstanceOf: function (type, obj) {
             // Cross-frame instanceof check
             return Object.prototype.toString.call(obj) === '[object ' + type + ']';
@@ -812,6 +819,9 @@
                             o.context,
                             [jqXHR, textStatus, errorThrown]
                         );
+                    })
+                    .always(function () {
+                        that._deinitProgressListener(o);
                     });
             };
             this._enhancePromise(promise);
@@ -913,6 +923,7 @@
                     }).fail(function (jqXHR, textStatus, errorThrown) {
                         that._onFail(jqXHR, textStatus, errorThrown, options);
                     }).always(function (jqXHRorResult, textStatus, jqXHRorError) {
+                        that._deinitProgressListener(options);
                         that._onAlways(
                             jqXHRorResult,
                             textStatus,