Add/context module #952
Merged
Add/context module #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set up context for wp-cloud and remove performance and staging accordingly
Passing run #7260 ↗︎
Details:
Review all test suite changes for PR #952 ↗︎ |
|||||||||||||||
47 failed tests on run #7126 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Help Page > Is Accessible |
Test Replay
Screenshots
Video
|
|
home.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Home Page > Site Info Exists |
Test Replay
Screenshots
Video
|
|
navigation.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Navigation > Admin submenu shouldn't exist inside app |
Test Replay
Screenshots
Video
|
|
settings.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Settings Page > Is Accessible |
Test Replay
Screenshots
Video
|
|
version-check.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Page > Is running the correct WP version |
Test Replay
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 47 specs in Cypress Cloud.
Review all test suite changes for PR #952 ↗︎
moves platform detection into context module moves adding all context to runtime into context module supports cleaned up autoloading and removes requires rearranges bootstrap for more linear representation of processing order
* release/3.8.5: Update ecomm and onboarding modules Update NPM dependencies Update composer dependencies # Conflicts: # composer.json # composer.lock
* main: Fix pretty permalink setup
* release/3.8.5: Update JS for ecomm
* release/3.9.0: minor react and wp package updates bump plugin version to 3.9.0 module updates # Conflicts: # composer.lock
* release/3.9.0: update matrix to run on 8.3 and not on 7.2 and 7.1 update marketplace module to 2.2.4 update onboarding module to 2.1.3 # Conflicts: # composer.lock
|
I've got the tests fixed on this. The same onboarding sitegen tests failing as on the release branch. I'll tag releases for the staging and performance modules and get them into this and then we can merge this into release branch. @wpscholar |
- Upgrading newfold-labs/wp-module-performance (1.3.1 => 1.4.0) - Upgrading newfold-labs/wp-module-staging (1.2.3 => 1.3.0)
* release/3.9.0: update config to skip sitegen tests for now
wpscholar
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding a context module and reading context for certain features.
Read platform context and when
atomicand disable certain features:Type of Change
Checklist
Further comments