Release/3.8.4 #927
Merged
Release/3.8.4 #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [newfold-labs/wp-module-onboarding](https://github.com/newfold-labs/wp-module-onboarding) from 1.12.0 to 1.12.1. - [Release notes](https://github.com/newfold-labs/wp-module-onboarding/releases) - [Commits](newfold-labs/wp-module-onboarding@1.12.0...1.12.1) --- updated-dependencies: - dependency-name: newfold-labs/wp-module-onboarding dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…fold-labs/wp-module-onboarding-1.12.1 Composer(deps): Bump newfold-labs/wp-module-onboarding from 1.12.0 to 1.12.1
* develop: Composer(deps): Bump newfold-labs/wp-module-onboarding
update node version in plugin, nvm and main workflows
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [react-use](https://github.com/streamich/react-use) from 17.4.3 to 17.5.0. - [Release notes](https://github.com/streamich/react-use/releases) - [Changelog](https://github.com/streamich/react-use/blob/master/CHANGELOG.md) - [Commits](streamich/react-use@v17.4.3...v17.5.0) --- updated-dependencies: - dependency-name: react-use dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@wordpress/dom-ready](https://github.com/WordPress/gutenberg/tree/HEAD/packages/dom-ready) from 3.49.0 to 3.50.0. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/dom-ready/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/dom-ready) --- updated-dependencies: - dependency-name: "@wordpress/dom-ready" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@wordpress/html-entities](https://github.com/WordPress/gutenberg/tree/HEAD/packages/html-entities) from 3.49.0 to 3.50.0. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/html-entities/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/html-entities) --- updated-dependencies: - dependency-name: "@wordpress/html-entities" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…op/actions/cache-4 GitHub Actions(deps): Bump actions/cache from 3 to 4
…/react-use-17.5.0 NPM(deps): Bump react-use from 17.4.3 to 17.5.0
…/wordpress/dom-ready-3.50.0 NPM(deps): Bump @wordpress/dom-ready from 3.49.0 to 3.50.0
…/wordpress/html-entities-3.50.0 NPM(deps): Bump @wordpress/html-entities from 3.49.0 to 3.50.0
- Upgrading newfold-labs/wp-module-ecommerce (v1.3.18 => v1.3.20) - Upgrading newfold-labs/wp-module-runtime (v1.0.7 => v1.0.9)
Bumps [@wordpress/env](https://github.com/WordPress/gutenberg/tree/HEAD/packages/env) from 9.1.0 to 9.2.0. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/env/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/env) --- updated-dependencies: - dependency-name: "@wordpress/env" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@wordpress/icons](https://github.com/WordPress/gutenberg/tree/HEAD/packages/icons) from 9.40.0 to 9.41.0. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/icons/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/icons) --- updated-dependencies: - dependency-name: "@wordpress/icons" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@reduxjs/toolkit](https://github.com/reduxjs/redux-toolkit) from 2.0.1 to 2.1.0. - [Release notes](https://github.com/reduxjs/redux-toolkit/releases) - [Commits](reduxjs/redux-toolkit@v2.0.1...v2.1.0) --- updated-dependencies: - dependency-name: "@reduxjs/toolkit" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [cypress](https://github.com/cypress-io/cypress) from 13.6.3 to 13.6.4. - [Release notes](https://github.com/cypress-io/cypress/releases) - [Changelog](https://github.com/cypress-io/cypress/blob/develop/CHANGELOG.md) - [Commits](cypress-io/cypress@v13.6.3...v13.6.4) --- updated-dependencies: - dependency-name: cypress dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Added links to Coming Soon page
…/wordpress/icons-9.41.0 NPM(deps): Bump @wordpress/icons from 9.40.0 to 9.41.0
…/wordpress/env-9.2.0 NPM Dev(deps-dev): Bump @wordpress/env from 9.1.0 to 9.2.0
…/cypress-13.6.4 NPM Dev(deps-dev): Bump cypress from 13.6.3 to 13.6.4
…/reduxjs/toolkit-2.1.0 NPM(deps): Bump @reduxjs/toolkit from 2.0.1 to 2.1.0
update ecommerce and runtime modules
- Upgrading newfold-labs/wp-module-coming-soon (1.1.18 => 1.2.0)
- Upgrading newfold-labs/wp-module-install-checker (1.0.2 => 1.0.3)
- Upgrading newfold-labs/wp-module-secure-passwords (1.1.0 => 1.1.1)
5 failed and 1 flaky tests on run #6898 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Click to buy > CTB modal is functional |
Test Replay
Screenshots
Video
|
|
| Click to buy > CTB fallback is functional |
Test Replay
Screenshots
Video
|
|
vendor/newfold-labs/wp-module-notifications/tests/cypress/integration/notifications.cy.js • 3 failed tests
vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/get-started-experience.cy.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Start Setup WP Experience Page > Check if events API call being made after radio buttons are clicked |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #927 ↗︎
it seems to stall since it is the first test to run and we end up skipping out of onboarding on a fresh docker install
…es for faster load
* main: Add `experimentalRunAllSpecs`
- Upgrading newfold-labs/wp-module-ctb (1.1.2 => 1.1.3) - Upgrading newfold-labs/wp-module-notifications (1.2.2 => 1.2.3) - Upgrading newfold-labs/wp-module-marketplace (2.2.0 => 2.2.1) - Upgrading newfold-labs/wp-module-global-ctb (1.0.9 => 1.0.10)
- Upgrading newfold-labs/wp-module-ecommerce (v1.3.20 => v1.3.21)
|
We're seeing some failing tests still but local tests pass when run individually and manual testing checks out as well. We'll need to do some more test investigations but in the meantime we can release this version, since we've done ample manual testing. This release does fix a stripe connection issue Need to look into the global-ctb module and the notifications module tests, they are consistently failing when run as part of the set but pass individually. There is most likely a cypress test conflict with other tests, but the module code seems to be fine. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Module updates as follows:
Also includes various minor updates for packages - mainly Wordpress packages. Some linting fixes. Updates build to use node v20.
Type of Change
Checklist
Further comments