Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up coming soon logic #892

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Clean up coming soon logic #892

merged 5 commits into from
Jan 17, 2024

Conversation

wpscholar
Copy link
Member

Proposed changes

Removes some filters that belong in the coming soon module. Cleans up logic to use Coming Soon APIs.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@wpscholar wpscholar added the bug Something isn't working label Jan 17, 2024
@wpscholar wpscholar requested a review from circlecube January 17, 2024 21:34
@wpscholar wpscholar self-assigned this Jan 17, 2024
@cypress Cypress
Copy link

cypress bot commented Jan 17, 2024 •
edited
Loading

1 flaky test on run #6481 ↗︎

0 308 43 0 Flakiness 1

Details:

update coming soon module
Project: Bluehost Brand Plugin Commit: 47ec4265d9
Status: Passed Duration: 19:37 💡
Started: Jan 17, 2024 11:21 PM Ended: Jan 17, 2024 11:41 PM
Flakiness  tests/cypress/integration/help.cy.js • 1 flaky test

View Output Video

Test Artifacts
Help Page > Is Accessible Test Replay Screenshots Video

Review all test suite changes for PR #892 ↗︎

@cypress Cypress
Copy link

cypress bot commented Jan 17, 2024

1 flaky test on run #6480 ↗︎

0 308 43 0 Flakiness 1

Details:

Merge 70f155c into 027f17a...
Project: Bluehost Brand Plugin Commit: ae4e7f41b0 ℹ️
Status: Passed Duration: 18:39 💡
Started: Jan 17, 2024 9:37 PM Ended: Jan 17, 2024 9:56 PM
Flakiness  tests/cypress/integration/help.cy.js • 1 flaky test

View Output Video

Test Artifacts
Help Page > Is Accessible Test Replay Screenshots Video

Review all test suite changes for PR #892 ↗︎

@circlecube circlecube merged commit ecf7554 into release/3.8.0 Jan 17, 2024
3 checks passed
@circlecube circlecube deleted the fix/coming-soon branch January 17, 2024 23:42
@cypress cypress bot mentioned this pull request Jan 18, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@circlecube circlecube circlecube approved these changes

Assignees

@wpscholar wpscholar

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpscholar @circlecube