Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update solutions module and solutions test exclusion #1469

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

This updates the solutions module and the cypress text exclusion to account for the test files being split. Splitting the files so that the Jetpack dependent test is in it's own file. Now when jetpack is unavailable in the env, we can still run the other solutions tests.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Dec 11, 2024
@circlecube circlecube added this to the December 18, 2024 Release milestone Dec 11, 2024
Copy link

cypress bot commented Dec 11, 2024

Bluehost Brand Plugin    Run #12256

Run Properties:  status check failed Failed #12256  •  git commit 05ebbbc7ef: update solutions module and solutions test exclusion
Project Bluehost Brand Plugin
Branch Review update/solutions-module-and-test-exclusion
Run status status check failed Failed #12256
Run duration 37m 23s
Commit git commit 05ebbbc7ef: update solutions module and solutions test exclusion
Committer Evan Mullins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 32
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 414
View all changes introduced in this branch ↗︎

Tests for review

Failed  vendor/newfold-labs/wp-module-solutions/tests/cypress/integration/solutions-app.cy.js • 1 failed test

View Output Video

Test Artifacts
My Plugins and Tools in Plugin App > My Plugins & Tools displays with Solution Test Replay Screenshots Video
Flakiness  vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/2-general-onboarding-flow/basic-info.cy.js • 1 flaky test

View Output Video

Test Artifacts
Basic Info Page > Check Drawer Activity Test Replay Screenshots Video

Copy link

cypress bot commented Dec 11, 2024

Bluehost Brand Plugin    Run #12257

Run Properties:  status check passed Passed #12257  •  git commit 3fee151406 ℹ️: Merge 05ebbbc7ef7a3ead76b611a6058a6ca68ffb5866 into 8301ccb549a4fe92a4ce0f259f09...
Project Bluehost Brand Plugin
Branch Review update/solutions-module-and-test-exclusion
Run status status check passed Passed #12257
Run duration 32m 49s
Commit git commit 3fee151406 ℹ️: Merge 05ebbbc7ef7a3ead76b611a6058a6ca68ffb5866 into 8301ccb549a4fe92a4ce0f259f09...
Committer Evan Mullins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 32
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 415
View all changes introduced in this branch ↗︎

@circlecube circlecube merged commit fd4c0c1 into develop Dec 11, 2024
3 of 5 checks passed
@circlecube circlecube deleted the update/solutions-module-and-test-exclusion branch December 11, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants