Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IDs to settings sections #1468

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

bradp
Copy link
Contributor

@bradp bradp commented Dec 11, 2024

Proposed changes

Adds IDs to settings sections to be able to link to them using the nfd-target param.

Before only one of these links works:

After they both work:

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@bradp bradp added the enhancement New feature or request label Dec 11, 2024
@circlecube circlecube changed the base branch from main to develop December 11, 2024 19:31
@circlecube circlecube added this to the December 18, 2024 Release milestone Dec 11, 2024
Copy link

cypress bot commented Dec 11, 2024

Bluehost Brand Plugin    Run #12251

Run Properties:  status check passed Passed #12251  •  git commit 375e95219a ℹ️: Merge 7c5bc3ca9d2eb41e3562927616c2d5ce3cc7bc57 into b14debd23cc4db50aecb0c16fd35...
Project Bluehost Brand Plugin
Branch Review feature/add-id-to-sections
Run status status check passed Passed #12251
Run duration 31m 55s
Commit git commit 375e95219a ℹ️: Merge 7c5bc3ca9d2eb41e3562927616c2d5ce3cc7bc57 into b14debd23cc4db50aecb0c16fd35...
Committer Brad Parbs
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 32
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 415
View all changes introduced in this branch ↗︎

Copy link

cypress bot commented Dec 11, 2024

Bluehost Brand Plugin    Run #12231

Run Properties:  status check failed Failed #12231  •  git commit 7c5bc3ca9d: Add IDs to settings sections
Project Bluehost Brand Plugin
Branch Review feature/add-id-to-sections
Run status status check failed Failed #12231
Run duration 32m 51s
Commit git commit 7c5bc3ca9d: Add IDs to settings sections
Committer Brad Parbs
View all properties for this run ↗︎

Test results
Tests that failed  Failures 6
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 33
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 403
View all changes introduced in this branch ↗︎

Tests for review

Failed  vendor/newfold-labs/wp-module-deactivation/tests/cypress/integration/deactivation-survey.cy.js • 6 failed tests

View Output Video

Test Artifacts
Plugin Deactivation Survey > Plugin deactivate link opens modal Test Replay Screenshots Video
Plugin Deactivation Survey > Step 1 content renders correctly Test Replay Screenshots Video
Plugin Deactivation Survey > Step 2 content renders correctly Test Replay Screenshots Video
Plugin Deactivation Survey > Skip action works Test Replay Screenshots Video
Plugin Deactivation Survey > Submit action works Test Replay Screenshots Video
Plugin Deactivation Survey > Modal closes properly Test Replay Screenshots Video
Flakiness  vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/2-general-onboarding-flow/basic-info.cy.js • 1 flaky test

View Output Video

Test Artifacts
Basic Info Page > Check Drawer Activity Test Replay Screenshots Video
Flakiness  vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/basic-info.cy.js • 1 flaky test

View Output Video

Test Artifacts
Basic Info Page > Check Drawer Activity Test Replay Screenshots Video

@circlecube circlecube merged commit 8301ccb into develop Dec 11, 2024
20 of 27 checks passed
@circlecube circlecube deleted the feature/add-id-to-sections branch December 11, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants