Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Installer and add PLS module #1345

Closed
wants to merge 1 commit into from
Closed

Update Installer and add PLS module #1345

wants to merge 1 commit into from
+61 −8

Conversation

arunshenoy99
Copy link
Member

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@cypress Cypress
Copy link

cypress bot commented Oct 9, 2024

Bluehost Brand Plugin    Run #10986

Run Properties:  status check passed Passed #10986  •  git commit e957e4ca05: Update Installer and add PLS module
Project Bluehost Brand Plugin
Run status status check passed Passed #10986
Run duration 26m 09s
Commit git commit e957e4ca05: Update Installer and add PLS module
Committer arunshenoy99
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 416

@cypress Cypress
Copy link

cypress bot commented Oct 9, 2024

Bluehost Brand Plugin    Run #10987

Run Properties:  status check passed Passed #10987  •  git commit 118a72bee9 ℹ️: Merge e957e4ca050283634b635b4969e974c9a2ecbf75 into 17d84b2446b9f790facbe1d63651...
Project Bluehost Brand Plugin
Run status status check passed Passed #10987
Run duration 25m 59s
Commit git commit 118a72bee9 ℹ️: Merge e957e4ca050283634b635b4969e974c9a2ecbf75 into 17d84b2446b9f790facbe1d63651...
Committer Arun Shenoy
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 416

@circlecube
Copy link
Member

Thanks @arunshenoy99, I did this in the solutions branch before I noticed this PR, so this is already taken care of. Closing

@circlecube circlecube closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunshenoy99 @circlecube