Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecommerce version bump to 1.3.44 #1312

Merged
merged 1 commit into from
Sep 24, 2024
Merged

ecommerce version bump to 1.3.44 #1312

merged 1 commit into from
Sep 24, 2024

Conversation

ramyakrishnai
Copy link
Contributor

Proposed changes

  • Move capabilities check behind init and is_admin

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@cypress Cypress
Copy link

cypress bot commented Sep 19, 2024

Bluehost Brand Plugin    Run #10510

Run Properties:  status check passed Passed #10510  •  git commit bfaf0e527d: ecommerce version bump to 1.3.44
Project Bluehost Brand Plugin
Branch Review update/ecommerce-version-1.3.44
Run status status check passed Passed #10510
Run duration 26m 09s
Commit git commit bfaf0e527d: ecommerce version bump to 1.3.44
Committer Ramya krishna
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 416
View all changes introduced in this branch ↗︎

@cypress Cypress
Copy link

cypress bot commented Sep 19, 2024 •
edited
Loading

Bluehost Brand Plugin    Run #10626

Run Properties:  status check passed Passed #10626  •  git commit ea33fe3945 ℹ️: Merge bfaf0e527d71a4c236768fd4ec67a2d1c7cb56b0 into f32d2eb1f8556bb95511806963ce...
Project Bluehost Brand Plugin
Branch Review update/ecommerce-version-1.3.44
Run status status check passed Passed #10626
Run duration 26m 16s
Commit git commit ea33fe3945 ℹ️: Merge bfaf0e527d71a4c236768fd4ec67a2d1c7cb56b0 into f32d2eb1f8556bb95511806963ce...
Committer Ramya
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 416
View all changes introduced in this branch ↗︎

@circlecube circlecube changed the base branch from develop to release/3.14.11 September 24, 2024 19:54
@circlecube circlecube merged commit 2aca561 into release/3.14.11 Sep 24, 2024
6 checks passed
@circlecube circlecube deleted the update/ecommerce-version-1.3.44 branch September 24, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@circlecube circlecube circlecube approved these changes

@wpscholar wpscholar Awaiting requested review from wpscholar

@wpalani wpalani Awaiting requested review from wpalani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramyakrishnai @circlecube