Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Update/ecommerce version bump 1.3.40 #1249

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

aratidgr8
Copy link
Contributor

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@aratidgr8 aratidgr8 requested review from wpscholar and wpalani August 14, 2024 13:49
@ramyakrishnai ramyakrishnai changed the base branch from main to develop August 14, 2024 13:58
Copy link

cypress bot commented Aug 14, 2024



Test summary

418 0 36 0Flakiness 1


Run details

Project Bluehost Brand Plugin
Status Passed
Commit b31f8aa ℹ️
Started Aug 14, 2024 2:01 PM
Ended Aug 14, 2024 2:28 PM
Duration 26:58 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


Flakiness

vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/sitetype-secondary.cy.js Flakiness
1 Get Started Site Type Secondary > Check for Event API call being made when different sub-categories are selected

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Member

@wpscholar wpscholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aratidgr8 Let's address the conflict in the composer.lock file and see why all the tests are failing in WordPress 6.4 in the matrix.

@wpalani wpalani added this to the August 21 Release milestone Aug 14, 2024
@wpalani
Copy link
Member

wpalani commented Aug 14, 2024

@aratidgr8 Let's address the conflict in the composer.lock file and see why all the tests are failing in WordPress 6.4 in the matrix.

I think merging develop into this branch would resolve the failing tests.

@wpalani wpalani merged commit 00caed6 into develop Aug 14, 2024
2 of 3 checks passed
@wpalani wpalani deleted the update/ecommerce-version-bump-1.3.40 branch August 14, 2024 21:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants