Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tailwind.config.js and postcss.config.js to .distignore #1071

Merged
merged 2 commits into from
May 15, 2024

Conversation

BrianHenryIE
Copy link
Contributor

Proposed changes

The plugin .zip file as downloaded from GitHub has two files that shouldn't be there: tailwind.config.js and postcss.config.js.

https://github.com/bluehost/bluehost-wordpress-plugin/releases/download/3.10.0/bluehost-wordpress-plugin.zip

Screenshot 2024-05-14 at 9 33 12 AM

Type of Change

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

I didn't actually build an archive to test it.

Copy link

cypress bot commented May 14, 2024

1 flaky test on run #8313 ↗︎

0 336 24 0 Flakiness 1

Details:

Merge 22a212c into 845bdfd...
Project: Bluehost Brand Plugin Commit: 4185ba7a57 ℹ️
Status: Passed Duration: 19:33 💡
Started: May 14, 2024 4:39 PM Ended: May 14, 2024 4:59 PM
Flakiness  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test

View Output Video

Test Artifacts
Commerce Home Page- Next Steps > Verify Next steps when experience level is novice Test Replay Screenshots Video

Review all test suite changes for PR #1071 ↗︎

Copy link

cypress bot commented May 14, 2024

1 flaky test on run #8294 ↗︎

0 389 50 0 Flakiness 1

Details:

Add `postcss.config.js` to `.distignore`
Project: Bluehost Brand Plugin Commit: 22a212cb0a
Status: Passed Duration: 23:51 💡
Started: May 14, 2024 4:35 PM Ended: May 14, 2024 4:59 PM
Flakiness  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test

View Output Video

Test Artifacts
Commerce Home Page- Next Steps > Verify Next steps when experience level is novice Test Replay Screenshots Video

Review all test suite changes for PR #1071 ↗︎

@wpalani
Copy link
Member

wpalani commented May 14, 2024

Approved. Just a heads up, PRs should be opened against the develop branch.

@wpalani wpalani changed the base branch from main to develop May 15, 2024 00:54
@wpalani wpalani merged commit d41d119 into develop May 15, 2024
24 checks passed
@wpalani wpalani deleted the add/tailwind-config-to-distignore branch May 15, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants