Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render bluehost-app-nav messages in the app nav #1055

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

wpalani
Copy link
Member

@wpalani wpalani commented Apr 26, 2024

Proposed changes

Render notifications with 'bluehost-app-nav' context in the app navigation.

More info can be found here: newfold-labs/wp-module-notifications#23

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@wpalani wpalani requested review from circlecube and wpscholar and removed request for circlecube and wpscholar April 26, 2024 00:04
@wpalani wpalani marked this pull request as draft April 26, 2024 00:06
@wpalani
Copy link
Member Author

wpalani commented Apr 26, 2024

Placing this back into draft since we need a notification module bump with the required changes for this to work.

Copy link

cypress bot commented Apr 26, 2024

4 failed tests on run #8160 ↗︎

4 406 29 0 Flakiness 0

Details:

Merge 507a79d into 2893dce...
Project: Bluehost Brand Plugin Commit: 14635c9f57 ℹ️
Status: Failed Duration: 24:14 💡
Started: Apr 30, 2024 6:28 PM Ended: Apr 30, 2024 6:52 PM
Failed  vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/5-AI-SiteGen-onboarding-flow/3-site-details.cy.js • 4 failed tests

View Output Video

Test Artifacts
SiteGen Site Details Step > Check for the header to be visible Test Replay Screenshots Video
SiteGen Site Details Step > Check for the placeholder text & input box hint to be visible before the prompt Test Replay Screenshots Video
SiteGen Site Details Step > Enter the prompt and see the box-info progress Test Replay Screenshots Video
SiteGen Site Details Step > Check if the Next Button is enabled and click Next Test Replay Screenshots Video

Review all test suite changes for PR #1055 ↗︎

@wpalani
Copy link
Member Author

wpalani commented Apr 30, 2024

Changes in module PR are merged here: #1057

Opening this PR again.

@wpalani wpalani requested review from circlecube and wpscholar April 30, 2024 18:24
@wpalani wpalani marked this pull request as ready for review April 30, 2024 18:25
Copy link

cypress bot commented Apr 30, 2024

5 failed tests on run #8161 ↗︎

5 404 29 0 Flakiness 0

Details:

Reorg deps
Project: Bluehost Brand Plugin Commit: 507a79d126
Status: Failed Duration: 23:54 💡
Started: Apr 30, 2024 6:28 PM Ended: Apr 30, 2024 6:52 PM
Failed  vendor/newfold-labs/wp-module-notifications/tests/cypress/integration/notifications.cy.js • 1 failed test

View Output Video

Test Artifacts
Notifications > Container Exists in plugin app Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/5-AI-SiteGen-onboarding-flow/3-site-details.cy.js • 4 failed tests

View Output Video

Test Artifacts
SiteGen Site Details Step > Check for the header to be visible Test Replay Screenshots Video
SiteGen Site Details Step > Check for the placeholder text & input box hint to be visible before the prompt Test Replay Screenshots Video
SiteGen Site Details Step > Enter the prompt and see the box-info progress Test Replay Screenshots Video
SiteGen Site Details Step > Check if the Next Button is enabled and click Next Test Replay Screenshots Video

Review all test suite changes for PR #1055 ↗︎

@wpalani
Copy link
Member Author

wpalani commented Apr 30, 2024

I re-ran the cypress tests and they are passing for the notification module. The failing tests are caused by the AI Site Gen module.

@wpalani wpalani merged commit 0425cc2 into develop Apr 30, 2024
4 of 9 checks passed
@wpalani wpalani deleted the add/app-nav-notifications branch April 30, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants