-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render bluehost-app-nav
messages in the app nav
#1055
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpalani
requested review from
circlecube and
wpscholar
and removed request for
circlecube and
wpscholar
April 26, 2024 00:04
Placing this back into draft since we need a notification module bump with the required changes for this to work. |
4 failed tests on run #8160 ↗︎
Details:
vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/5-AI-SiteGen-onboarding-flow/3-site-details.cy.js • 4 failed testsReview all test suite changes for PR #1055 ↗︎ |
Changes in module PR are merged here: #1057 Opening this PR again. |
I re-ran the cypress tests and they are passing for the notification module. The failing tests are caused by the AI Site Gen module. |
wpscholar
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Render notifications with
'bluehost-app-nav'
context in the app navigation.More info can be found here: newfold-labs/wp-module-notifications#23
Type of Change
Checklist
Further comments