Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in current stable (version 121.0.6167.139.1) makes pages to crash on certain actions [BUG] #206

Open
ggrocca opened this issue Feb 9, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@ggrocca
Copy link

ggrocca commented Feb 9, 2024

Describe the bug
When clicking a button on certain pages, an entire subframe or tab crashes. This does not happen on any button - just some, but those that do, they always crash. I think the crash depends on which javascript code or general action is associated to the button callback. I've noticed it immediately after install in two situations: in disqus subframes, and in an intranet app in my office. I bet this happens in several other situations, but at that point I didn't try anything else and I've just installed the previous stable.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any page that loads disqus comments, for example here
  2. Login to disqus.
  3. Write and publish any comment, for example test test test.
  4. After having published the comment, click on the "modify" button under it.
  5. See the whole disqus subframe crash.

Expected behavior
No frames or tabs crashing.

Screenshots
Didn't make one but I can provide one if it can be useful

Desktop (please complete the following information):

  • macOS X Mojave
  • Build 121.0.6167.139.1

Additional Info
This happens on the latest stable only. I've tested both versions 1257388 (123.0.6288.0, current latest) and 120.0.6099.199.1 (previous stable) and they work correctly.

@ggrocca ggrocca added the bug Something isn't working label Feb 9, 2024
@Wowfunhappy
Copy link

I can confirm this is occurring on 10.9.5 in the test case with Disqus comments.

@Wowfunhappy
Copy link

Oh yay, this generates a crash report. Looks like it's something related to focus rings? (I've attached two reports for good measure, but they're perfectly consistent.)
Archive.zip

@Wowfunhappy
Copy link

This appears to have been fixed as of 121.0.6167.160.1! This issue can be closed.

blueboxd pushed a commit that referenced this issue May 16, 2024
This flag was changed in https://crrev.com/c/5237233, but missed in
that CL due to concurrent editing of the file.

(cherry picked from commit 53cdf72)

Bug: 330202418, 329556843
Change-Id: I359eca1fe7b5802852459e23a6dc9e51954f946f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5378704
Reviewed-by: Elad Alon <[email protected]>
Commit-Queue: Elad Alon <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1274792}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5388449
Commit-Queue: Tove Petersson <[email protected]>
Reviewed-by: Tove Petersson <[email protected]>
Cr-Commit-Position: refs/branch-heads/6367@{#206}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants