Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
… into master.lion
  • Loading branch information
bluebox authored and bluebox committed Sep 13, 2020
2 parents b8df22c + ac5732f commit f53c4f6
Show file tree
Hide file tree
Showing 2,747 changed files with 46,584 additions and 30,338 deletions.
2 changes: 1 addition & 1 deletion .gn
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ no_check_targets = [
"//third_party/blink/renderer/modules/font_access:*", # 3 errors
"//third_party/blink/renderer/modules/peerconnection:*", # 43 errors
"//third_party/blink/renderer/modules:*", # 321 errors
"//third_party/blink/renderer/platform:*", # 72 errors
"//third_party/blink/renderer/platform:*", # 10 errors

"//third_party/breakpad:*", # 34 errors
"//third_party/ced/*",
Expand Down
2 changes: 2 additions & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ Anuj Kumar Sharma <[email protected]>
Arjun Karthik <[email protected]>
Arman Ghotb <[email protected]>
Armin Burgmeier <[email protected]>
Arnaud Coomans <[email protected]>
Arnaud Mandy <[email protected]>
Arnaud Renevier <[email protected]>
Arpita Bahuguna <[email protected]>
Expand Down Expand Up @@ -658,6 +659,7 @@ Martin Rogalla <[email protected]>
Martina Kollarova <[email protected]>
Masahiro Yado <[email protected]>
Masaru Nishida <[email protected]>
Masayuki Wakizaka <[email protected]>
Matej Knopp <[email protected]>
Matheus Bratfisch <[email protected]>
Mathias Bynens <[email protected]>
Expand Down
1 change: 0 additions & 1 deletion BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,6 @@ group("gn_all") {
"//chrome/android:chrome_junit_tests",
"//chrome/android:chrome_public_apk",
"//chrome/android:chrome_public_test_apk",
"//chrome/android/features/media_router:media_router_junit_tests",
"//chrome/browser/android/examples/custom_tabs_client:custom_tabs_client_example_apk",
"//chrome/browser/android/examples/partner_browser_customizations_provider:partner_browser_customizations_example_apk",
"//chrome/test/chromedriver/test/webview_shell:chromedriver_webview_shell_apk",
Expand Down
36 changes: 18 additions & 18 deletions DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling Skia
# and whatever else without interference from each other.
'skia_revision': '18f6a54fc3cea32dd92a28e8808e4525c5180782',
'skia_revision': 'b711737c1384ae2179ab65d11cb36e4a5462f225',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling V8
# and whatever else without interference from each other.
Expand All @@ -207,15 +207,15 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling ANGLE
# and whatever else without interference from each other.
'angle_revision': '65dcbe124508f9799348fd4828cbb0f76cf80671',
'angle_revision': '183a454b9d5474abb097da2c527805a9c7379a6c',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling SwiftShader
# and whatever else without interference from each other.
'swiftshader_revision': '41974f57973ebcdab4cfde6cc60354f6b79a5901',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling PDFium
# and whatever else without interference from each other.
'pdfium_revision': 'b6525ec96573078b680538b7c4e12acce59d4574',
'pdfium_revision': '40d3f47d189c1ac36b14f3fe6d6ba9ce4c0a7d7e',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling BoringSSL
# and whatever else without interference from each other.
Expand Down Expand Up @@ -258,15 +258,15 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling catapult
# and whatever else without interference from each other.
'catapult_revision': '13bf1254829136fb3df678699236ba9eb5d87587',
'catapult_revision': 'e53ee0c93173e3b9452c8693e8e0ad07364fd801',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling libFuzzer
# and whatever else without interference from each other.
'libfuzzer_revision': 'debe7d2d1982e540fbd6bd78604bf001753f9e74',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling devtools-frontend
# and whatever else without interference from each other.
'devtools_frontend_revision': 'fb8d5f7d60cbab72a749ec03c1d9019629c837d4',
'devtools_frontend_revision': '87a2e015f06ed56b35cadddfa2637360a50d4eee',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling libprotobuf-mutator
# and whatever else without interference from each other.
Expand Down Expand Up @@ -318,11 +318,11 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling feed
# and whatever else without interference from each other.
'dawn_revision': '9427c97d9c2917d66e79e49ffaa718aac2e7d6ad',
'dawn_revision': 'dbd34449af20f2d026b1e7f959073e254066ec83',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling feed
# and whatever else without interference from each other.
'quiche_revision': 'edf934d71e960173dcb1f257b8d228ff6c4f9607',
'quiche_revision': '5c52ad843f8a33546cc17f4e7f05e6ab0df92c43',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling ios_webkit
# and whatever else without interference from each other.
Expand Down Expand Up @@ -545,7 +545,7 @@ deps = {
},

'src/ios/third_party/material_components_ios/src': {
'url': Var('chromium_git') + '/external/github.com/material-components/material-components-ios.git' + '@' + '3aace45a832e030d2e7812e310ffb4488e0bf77b',
'url': Var('chromium_git') + '/external/github.com/material-components/material-components-ios.git' + '@' + '6543af21be74965abb609e792d744f8f76fe4c63',
'condition': 'checkout_ios',
},

Expand Down Expand Up @@ -876,7 +876,7 @@ deps = {
# Tools used when building Chrome for Chrome OS. This affects both the Simple
# Chrome workflow, as well as the chromeos-chrome ebuild.
'src/third_party/chromite': {
'url': Var('chromium_git') + '/chromiumos/chromite.git' + '@' + '607aa13c8b9aa57ef1fa23cc044b969ae6757db2',
'url': Var('chromium_git') + '/chromiumos/chromite.git' + '@' + 'bcd69ba12e0508c670704a630a42ecc9d7776220',
'condition': 'checkout_chromeos',
},

Expand All @@ -896,7 +896,7 @@ deps = {
},

'src/third_party/depot_tools':
Var('chromium_git') + '/chromium/tools/depot_tools.git' + '@' + 'fb6d901df74da0f693b98f84715b0a381db9e8f0',
Var('chromium_git') + '/chromium/tools/depot_tools.git' + '@' + 'a1e15498cd2dd4b2cc8826e65dbee2c2b0b63aa9',

'src/third_party/devtools-frontend/src':
Var('chromium_git') + '/devtools/devtools-frontend' + '@' + Var('devtools_frontend_revision'),
Expand Down Expand Up @@ -947,7 +947,7 @@ deps = {
Var('chromium_git') + '/codecs/libgav1.git' + '@' + 'a9449e612bc251b4271bbe1e3a0d12e9809bf74c',

'src/third_party/glslang/src':
Var('chromium_git') + '/external/github.com/KhronosGroup/glslang.git' + '@' + '6a6e311d81ddfa6debf5659f05c311e3b57b5f77',
Var('chromium_git') + '/external/github.com/KhronosGroup/glslang.git' + '@' + '759ae5aec02bd6fe5f58a9c7cd6c98cc1968c7b5',

'src/third_party/google_toolbox_for_mac/src': {
'url': Var('chromium_git') + '/external/github.com/google/google-toolbox-for-mac.git' + '@' + Var('google_toolbox_for_mac_revision'),
Expand Down Expand Up @@ -1121,7 +1121,7 @@ deps = {
},

'src/third_party/libjpeg_turbo':
Var('chromium_git') + '/chromium/deps/libjpeg_turbo.git' + '@' + '9d4f8005bc6c888e66b00fd00188531ee9bd3344',
Var('chromium_git') + '/chromium/deps/libjpeg_turbo.git' + '@' + '8ca19625de302b0af290e3e0cdeff24a1c272d39',

'src/third_party/liblouis/src': {
'url': Var('chromium_git') + '/external/liblouis-github.git' + '@' + '03d7d72d983d47c17f7de95bbeae89fe33e41943',
Expand Down Expand Up @@ -1249,7 +1249,7 @@ deps = {
},

'src/third_party/perfetto':
Var('android_git') + '/platform/external/perfetto.git' + '@' + '3b19b9d3347ff6b5510160f64edb34c036b241bc',
Var('android_git') + '/platform/external/perfetto.git' + '@' + '9edd1a906f57a995531db1050629b608424ee202',

'src/third_party/perl': {
'url': Var('chromium_git') + '/chromium/deps/perl.git' + '@' + '6f3e5028eb65d0b4c5fdd792106ac4c84eee1eb3',
Expand Down Expand Up @@ -1285,7 +1285,7 @@ deps = {
},

'src/third_party/quic_trace/src':
Var('chromium_git') + '/external/github.com/google/quic-trace.git' + '@' + 'a3f901c6a99e786ed0fa58a89927f630af17a90c',
Var('chromium_git') + '/external/github.com/google/quic-trace.git' + '@' + '2dccbe8e996d43c6d93b69e4f6d024f015e8c488',

'src/third_party/pywebsocket3/src':
Var('chromium_git') + '/external/github.com/GoogleChromeLabs/pywebsocket3.git' + '@' + 'faf478a0453ceae78f2a3bc11c6c21e13362628f',
Expand Down Expand Up @@ -1471,7 +1471,7 @@ deps = {
},

'src/third_party/webrtc':
Var('webrtc_git') + '/src.git' + '@' + 'fc83cdc8198b0609f8986313ef48e565b558e8a7',
Var('webrtc_git') + '/src.git' + '@' + '71d7c8e3cdd61b69d09fc392b93cc8c461168f0d',

'src/third_party/libgifcodec':
Var('skia_git') + '/libgifcodec' + '@'+ Var('libgifcodec_revision'),
Expand Down Expand Up @@ -1543,15 +1543,15 @@ deps = {
Var('chromium_git') + '/v8/v8.git' + '@' + Var('v8_revision'),

'src-internal': {
'url': 'https://chrome-internal.googlesource.com/chrome/src-internal.git@eed10d12ed495ff3910459c193438c1dc51338ad',
'url': 'https://chrome-internal.googlesource.com/chrome/src-internal.git@7214110d995df5f856022330b0fe9fd34c79cf31',
'condition': 'checkout_src_internal',
},

'src/chromeos/components/help_app_ui/resources/prod': {
'packages': [
{
'package': 'chromeos_internal/apps/help_app/app',
'version': 'ewmYZK3dZxBbgR06k6qpzdRqlikpeAfsd40KuNLCOSYC',
'version': '_QUWBlAB3zSpGuENS-ygkl0rPTkolBKtlvjdPANqPVEC',
},
],
'condition': 'checkout_chromeos and checkout_src_internal',
Expand All @@ -1562,7 +1562,7 @@ deps = {
'packages': [
{
'package': 'chromeos_internal/apps/media_app/app',
'version': 'rr3VhMXsq7y_PFGfYuF4xO5k6h8d3dTyYtD20gc4jK8C',
'version': 'TYOLo4rtVMC49lR5yvwouWlMavyGxEBRTimkq5QQimEC',
},
],
'condition': 'checkout_chromeos and checkout_src_internal',
Expand Down
2 changes: 1 addition & 1 deletion PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,7 @@
(
'Improper use of Microsoft::WRL::ComPtr<T>::GetAddressOf() has been ',
'implicated in a few leaks. ReleaseAndGetAddressOf() is safe but ',
'operator& is generally recommended. So always use operator& instead. '
'operator& is generally recommended. So always use operator& instead. ',
'See http://crbug.com/914910 for more conversion guidance.'
),
True,
Expand Down
6 changes: 4 additions & 2 deletions WATCHLISTS
Original file line number Diff line number Diff line change
Expand Up @@ -2049,6 +2049,7 @@
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
Expand Down Expand Up @@ -2373,9 +2374,10 @@
'chromeos_wifi_sync': ['[email protected]',
'[email protected]',
'[email protected]'],
'chromevox': ['[email protected]',
'chromevox': ['[email protected]',
'[email protected]',
'[email protected]',
'akihiroota@chromium.org'],
'josiahk+watch@chromium.org'],
'clang_update': ['[email protected]',
'[email protected]',
'[email protected]',
Expand Down
3 changes: 2 additions & 1 deletion android_webview/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,9 @@ include_rules = [
"+services/service_manager/public",
"+services/viz/public/mojom",
"+skia",
"+third_party/skia/include",
"+third_party/blink/public/common/web_preferences",
"+third_party/boringssl/src/include",
"+third_party/skia/include",
"+ui/android",
"+ui/base",
"+ui/gfx",
Expand Down
15 changes: 9 additions & 6 deletions android_webview/browser/aw_content_browser_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@
#include "content/public/common/service_names.mojom.h"
#include "content/public/common/url_constants.h"
#include "content/public/common/user_agent.h"
#include "content/public/common/web_preferences.h"
#include "mojo/public/cpp/bindings/pending_associated_receiver.h"
#include "mojo/public/cpp/bindings/pending_receiver.h"
#include "mojo/public/cpp/bindings/self_owned_receiver.h"
Expand All @@ -100,6 +99,7 @@
#include "services/service_manager/public/cpp/binder_registry.h"
#include "services/service_manager/public/cpp/interface_provider.h"
#include "third_party/blink/public/common/loader/url_loader_throttle.h"
#include "third_party/blink/public/common/web_preferences/web_preferences.h"
#include "third_party/blink/public/mojom/loader/resource_load_info.mojom-shared.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/base/resource/resource_bundle_android.h"
Expand Down Expand Up @@ -456,11 +456,14 @@ AwContentBrowserClient::CreateQuotaPermissionContext() {
content::GeneratedCodeCacheSettings
AwContentBrowserClient::GetGeneratedCodeCacheSettings(
content::BrowserContext* context) {
// If we pass 0 for size, disk_cache will pick a default size using the
// heuristics based on available disk size. These are implemented in
// disk_cache::PreferredCacheSize in net/disk_cache/cache_util.cc.
// WebView limits the main HTTP cache to 20MB; we need to set a comparable
// limit for the code cache since the source file needs to be in the HTTP
// cache for the code cache entry to be used. There are two code caches that
// both use this value, so we pass 10MB to keep the total disk usage to
// roughly 2x what it was before the code cache was implemented.
// TODO(crbug/893318): webview should have smarter cache sizing logic.
AwBrowserContext* browser_context = static_cast<AwBrowserContext*>(context);
return content::GeneratedCodeCacheSettings(true, 0,
return content::GeneratedCodeCacheSettings(true, 10 * 1024 * 1024,
browser_context->GetCacheDir());
}

Expand Down Expand Up @@ -598,7 +601,7 @@ void AwContentBrowserClient::GetAdditionalMappedFilesForChildProcess(

void AwContentBrowserClient::OverrideWebkitPrefs(
content::RenderViewHost* rvh,
content::WebPreferences* web_prefs) {
blink::web_pref::WebPreferences* web_prefs) {
AwSettings* aw_settings = AwSettings::FromWebContents(
content::WebContents::FromRenderViewHost(rvh));
if (aw_settings) {
Expand Down
2 changes: 1 addition & 1 deletion android_webview/browser/aw_content_browser_client.h
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ class AwContentBrowserClient : public content::ContentBrowserClient {
int child_process_id,
content::PosixFileDescriptorInfo* mappings) override;
void OverrideWebkitPrefs(content::RenderViewHost* rvh,
content::WebPreferences* web_prefs) override;
blink::web_pref::WebPreferences* web_prefs) override;
std::vector<std::unique_ptr<content::NavigationThrottle>>
CreateThrottlesForNavigation(
content::NavigationHandle* navigation_handle) override;
Expand Down
20 changes: 10 additions & 10 deletions android_webview/browser/aw_settings.cc
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@
#include "content/public/browser/renderer_preferences_util.h"
#include "content/public/browser/storage_partition.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/web_preferences.h"
#include "net/http/http_util.h"
#include "third_party/blink/public/common/web_preferences/web_preferences.h"
#include "third_party/blink/public/mojom/renderer_preferences.mojom.h"

using base::android::ConvertJavaStringToUTF16;
using base::android::ConvertUTF8ToJavaString;
using base::android::JavaParamRef;
using base::android::ScopedJavaLocalRef;
using content::WebPreferences;
using blink::web_pref::WebPreferences;

namespace android_webview {

Expand Down Expand Up @@ -344,27 +344,27 @@ void AwSettings::PopulateWebPreferencesLocked(JNIEnv* env,
render_view_host_ext->SetTextZoomFactor(text_size_percent / 100.0f);
}

web_prefs->standard_font_family_map[content::kCommonScript] =
web_prefs->standard_font_family_map[blink::web_pref::kCommonScript] =
ConvertJavaStringToUTF16(
Java_AwSettings_getStandardFontFamilyLocked(env, obj));

web_prefs->fixed_font_family_map[content::kCommonScript] =
web_prefs->fixed_font_family_map[blink::web_pref::kCommonScript] =
ConvertJavaStringToUTF16(
Java_AwSettings_getFixedFontFamilyLocked(env, obj));

web_prefs->sans_serif_font_family_map[content::kCommonScript] =
web_prefs->sans_serif_font_family_map[blink::web_pref::kCommonScript] =
ConvertJavaStringToUTF16(
Java_AwSettings_getSansSerifFontFamilyLocked(env, obj));

web_prefs->serif_font_family_map[content::kCommonScript] =
web_prefs->serif_font_family_map[blink::web_pref::kCommonScript] =
ConvertJavaStringToUTF16(
Java_AwSettings_getSerifFontFamilyLocked(env, obj));

web_prefs->cursive_font_family_map[content::kCommonScript] =
web_prefs->cursive_font_family_map[blink::web_pref::kCommonScript] =
ConvertJavaStringToUTF16(
Java_AwSettings_getCursiveFontFamilyLocked(env, obj));

web_prefs->fantasy_font_family_map[content::kCommonScript] =
web_prefs->fantasy_font_family_map[blink::web_pref::kCommonScript] =
ConvertJavaStringToUTF16(
Java_AwSettings_getFantasyFontFamilyLocked(env, obj));

Expand Down Expand Up @@ -438,8 +438,8 @@ void AwSettings::PopulateWebPreferencesLocked(JNIEnv* env,

web_prefs->autoplay_policy =
Java_AwSettings_getMediaPlaybackRequiresUserGestureLocked(env, obj)
? content::AutoplayPolicy::kUserGestureRequired
: content::AutoplayPolicy::kNoUserGestureRequired;
? blink::web_pref::AutoplayPolicy::kUserGestureRequired
: blink::web_pref::AutoplayPolicy::kNoUserGestureRequired;

ScopedJavaLocalRef<jstring> url =
Java_AwSettings_getDefaultVideoPosterURLLocked(env, obj);
Expand Down
6 changes: 4 additions & 2 deletions android_webview/browser/aw_settings.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@
#include "base/android/scoped_java_ref.h"
#include "content/public/browser/web_contents_observer.h"

namespace content {
namespace blink {
namespace web_pref {
struct WebPreferences;
}
} // namespace blink

namespace android_webview {

Expand Down Expand Up @@ -83,7 +85,7 @@ class AwSettings : public content::WebContentsObserver {
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj);

void PopulateWebPreferences(content::WebPreferences* web_prefs);
void PopulateWebPreferences(blink::web_pref::WebPreferences* web_prefs);
bool GetAllowFileAccess();
bool IsDarkMode(JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
<provider # DIFF-ANCHOR: a5e78e63
android:authorities="$PACKAGE.LicenseContentProvider"
android:exported="true"
android:grantUriPermissions="true"
android:name="org.chromium.android_webview.nonembedded.LicenseContentProvider"
android:process=":webview_apk">
</provider> # DIFF-ANCHOR: a5e78e63
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
<provider # DIFF-ANCHOR: a5e78e63
android:authorities="$PACKAGE.LicenseContentProvider"
android:exported="true"
android:grantUriPermissions="true"
android:name="org.chromium.android_webview.nonembedded.LicenseContentProvider"
android:process=":webview_apk">
</provider> # DIFF-ANCHOR: a5e78e63
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
@RunWith(AwJUnit4ClassRunner.class)
@CommandLineFlags.Add({ContentSwitches.HOST_RESOLVER_RULES + "=MAP * 127.0.0.1"})
@Batch(Batch.PER_CLASS)
@DisabledTest(message = "http://crbug.com/1126917")
public class AwSettingsTest {
@Rule
public AwActivityTestRule mActivityTestRule =
Expand Down
Loading

0 comments on commit f53c4f6

Please sign in to comment.