Skip to content

Commit

Permalink
Revert "Reland "macOS Signing Scripts: Default to using notarytool fo…
Browse files Browse the repository at this point in the history
…r notarization.""

This reverts commit 679f936.

Reason for revert: https://crbug.com/1440120

Original change's description:
> Reland "macOS Signing Scripts: Default to using notarytool for notarization."
>
> This is a reland of commit 741ed96
>
> Work has been done internally to enable re-landing this. This CL
> can still be safely reverted if it causes breakage.
>
> Original change's description:
> > macOS Signing Scripts: Default to using notarytool for notarization.
> >
> > This will switch official builds to use notarytool rather than altool.
> > The CL can be safely reverted if any unexpected errors are encountered.
> >
> > Bug: 1217659
> > Change-Id: If6ba33a93b135bb9ae9b1b04444380c8da900e5d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557773
> > Reviewed-by: Mark Mentovai <[email protected]>
> > Commit-Queue: Robert Sesek <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#986708}
>
> Bug: 1217659
> Change-Id: Ica60e04c0c0eb1ca645a0a8fd7341d46490e25bd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4476227
> Reviewed-by: Mark Mentovai <[email protected]>
> Commit-Queue: Robert Sesek <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1135543}

Bug: 1217659, 1440120
Change-Id: Ife167388274d2d8636f00b6450e712e64b01e1ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4479989
Reviewed-by: Mark Mentovai <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1135858}
  • Loading branch information
rsesek authored and Chromium LUCI CQ committed Apr 26, 2023
1 parent a2af0f0 commit e4fc831
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion chrome/installer/mac/signing/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def notarization_tool(self):
notary service. The values are from the signing.model.NotarizationTool
enum.
"""
return self._notarization_tool or NotarizationTool.NOTARYTOOL
return self._notarization_tool or NotarizationTool.ALTOOL

@property
def notarization_tool_path(self):
Expand Down

0 comments on commit e4fc831

Please sign in to comment.