Skip to content

Commit

Permalink
Revert "[TTS] Reenable CSMTest suite with longer timeout."
Browse files Browse the repository at this point in the history
This reverts commit a5ef867.

Reason for revert: Still flaking a lot.

Original change's description:
> [TTS] Reenable CSMTest suite with longer timeout.
> 
> Speculatively re-enables the ContextualSearchManagerTest suite with
> the hope that the mysterious underlying flakiness issue has gone
> away, or that the longer timeout in this version of the code will
> help.
> 
> Original disabling CL: https://crrev.com/c/2088007
> 
> [email protected]
> 
> BUG=1058362
> 
> Change-Id: I02ea4f209b86b730cc6f40622839ffb12f3753c7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094245
> Commit-Queue: Donn Denman <[email protected]>
> Reviewed-by: Donn Denman <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#748287}

[email protected],[email protected]

Change-Id: Ibb00c69f96bf4bbc54776540c813e68f86598fc3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1058362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095963
Reviewed-by: Donn Denman <[email protected]>
Commit-Queue: Donn Denman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#748464}
  • Loading branch information
Donn Denman authored and Commit Bot committed Mar 10, 2020
1 parent b534fbd commit cbd4502
Showing 1 changed file with 6 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,11 @@
"disable-features=" + ChromeFeatureList.CONTEXTUAL_SEARCH_ML_TAP_SUPPRESSION})
@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)
@RetryOnFailure
//
// NOTE -- THIS WHOLE TEST CLASS IS TEMPORARILY DISABLED:
//
@DisabledTest(message = "See https://crbug.com/1058362")
//
public class ContextualSearchManagerTest {
@Rule
public ChromeActivityTestRule<ChromeActivity> mActivityTestRule =
Expand All @@ -142,7 +147,7 @@ public class ContextualSearchManagerTest {
private static final String LOW_PRIORITY_INVALID_SEARCH_ENDPOINT = "/s/invalid";
private static final String CONTEXTUAL_SEARCH_PREFETCH_PARAM = "&pf=c";
// The number of ms to delay startup for all tests.
private static final int ACTIVITY_STARTUP_DELAY_MS = 5000; // TODO(donnd): reduce!
private static final int ACTIVITY_STARTUP_DELAY_MS = 1000;

private ActivityMonitor mActivityMonitor;
private ContextualSearchFakeServer mFakeServer;
Expand Down

0 comments on commit cbd4502

Please sign in to comment.