chore: add getter for specId #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
approved these changes
Jan 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CfgEnv no longer has the specId. this is now in the journaledstate
This adds a getter to the EmvContext, though it's not obvious to me where the SpecId in the journaledState is properly set, in the new functions this is always, latest.
if the EvmContext has access to the spec id then it's not clear why it gets it as argument:
https://github.com/bluealloy/revm/blob/main/crates/revm/src/context.rs#L214-L214
so I'm not 100% about this getter, but it's definitely useful the get access to the evm's specid during inspection.