Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transient_storage): set previous value in journal #585

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

rakita
Copy link
Member

@rakita rakita commented Aug 6, 2023

Journaled values (Value that we revert to) should have been the previous value and not the new value

Introduced in initial EIP here: #546
found when running eth tests. Tests will be added in ci in next commit.

@tynes fyi

@rakita rakita merged commit fe6c54e into main Aug 6, 2023
@tynes
Copy link
Contributor

tynes commented Aug 6, 2023

Thank you for fixing this

@rakita rakita deleted the fix/transient_storage_journaled_value branch August 25, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants