Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Error for EVMError #559

Merged
merged 1 commit into from
Jul 28, 2023
Merged

feat: Implement Error for EVMError #559

merged 1 commit into from
Jul 28, 2023

Conversation

oblique
Copy link
Contributor

@oblique oblique commented Jul 24, 2023

No description provided.

rakita
rakita reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentionally left it without thiserror

@oblique
Copy link
Contributor Author

oblique commented Jul 24, 2023

Just curious, what was the intention?

@oblique
Copy link
Contributor Author

oblique commented Jul 24, 2023

Is it because of no_std? In that case I can manually impl the Error and feature gate it with #[cfg(feature = "std")]

@oblique oblique force-pushed the feat/impl-error branch 2 times, most recently from 8d1ca6b to 694cdde Compare July 24, 2023 23:02
@oblique oblique marked this pull request as draft July 24, 2023 23:09
@oblique oblique force-pushed the feat/impl-error branch 2 times, most recently from be00d24 to aed8d73 Compare July 24, 2023 23:14
@oblique oblique requested a review from rakita July 24, 2023 23:14
@oblique
Copy link
Contributor Author

oblique commented Jul 24, 2023

What about now? Error is implemented only in case of std feature.

@oblique oblique marked this pull request as ready for review July 24, 2023 23:16
rakita
rakita approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, lets add it as is!

@rakita rakita merged commit 781c8cc into bluealloy:main Jul 28, 2023
@github-actions github-actions bot mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita rakita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oblique @rakita