Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(revm): EIP-3155 tracer tx output without debug artefact #552

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

perama-v
Copy link
Contributor

Description

EIP-3155 tracer output section included debug (?) artefacts

Changes

  • Use non-debug newline-delineated JSON representation.
  • Include 0x-prefixed hex encoding for output field.

Before:

{"pc":379,"op":253,"gas":"0x66048","gasCost":"0x0","memSize":1024,"stack":["0xda218207","0x88","0x80","0x1c0","0x200","0x7a250d5630b4cf539739df2c5dacb4c659f2488d","0x0","0x240","0x0","0x2a0","0x631","0x80","0x240","0x200","0x7a250d5630b4cf539739df2c5dacb4c659f2488d","0x0","0x3","0x0","0x0","0x0","0x64","0x300"],"depth":1,"opName":"REVERT"}
"{\"output\":\"b\\\"\\\\x08\\\\xc3y\\\\xa0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0 \\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\x06On god\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\\0\\\"\",\"gasUsed\":\"0x66048\"}"

After

{"pc":379,"op":253,"gas":"0x66048","gasCost":"0x0","memSize":1024,"stack":["0xda218207","0x88","0x80","0x1c0","0x200","0x7a250d5630b4cf539739df2c5dacb4c659f2488d","0x0","0x240","0x0","0x2a0","0x631","0x80","0x240","0x200","0x7a250d5630b4cf539739df2c5dacb4c659f2488d","0x0","0x3","0x0","0x0","0x0","0x64","0x300"],"depth":1,"opName":"REVERT"}
{"output":"0x08c379a0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000064f6e20676f640000000000000000000000000000000000000000000000000000","gasUsed":"0x66048"}

Discussion

The EIP is not explicit (empty table cell) about the data type in output.

While EVMOne has hex encoding without an 0x-prefix, the prefix seemed more appropriate for a JSON hex-number.

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applogize for delay on this and others PR's

@rakita rakita merged commit 4686cb3 into bluealloy:main Jul 28, 2023
@perama-v
Copy link
Contributor Author

Not at all, thanks for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants