fix(op): move l1block loading to verification #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
force-pushed
the
rakita/load_l1block_ver
branch
from
be03d46 to
40818a8
Compare
rakita
commented
Jan 6, 2025
| let l1_block_info = | ||
| crate::optimism::L1BlockInfo::try_fetch(&mut context.evm.inner.db, SPEC::SPEC_ID) | ||
| .map_err(EVMError::Database)?; | ||
| context.evm.inner.l1_block_info = Some(l1_block_info); |
There was a problem hiding this comment.
@mattsse I added this part where the load is only done if l1_block_info field is None.
This can be a small optimization for the future where this is set before execution.
And every time after Revm finishes it will be set to None so it does not get that weird side effect. So it will function as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.