-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply latest EIP-7702 changes #1850
Conversation
@rakita how should we deal with failing state tests? |
We should wait for tests to be released before merging it. In general, changes look good, but there are two things here:
|
Seems that in devnet-5 https://notes.ethereum.org/@ethpandaops/pectra-devnet-5
For devnet-4 changes we were pretty much always just pushing them to main in both alloy and reth. Separate branch was just for convenience when providing devops team with the latest version |
Cool, good link, it is in next releas,more on changes here: https://discord.com/channels/595666850260713488/745077610685661265/1302999973167759416 Let's delay it until Mekong is near it's end.
I want to break the notion that this was good behavior, as it pulls the narative that participating in devnet would require publishing crates. Having this charges in a branch is more on the lime of concept of dev chain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Applies changes from ethereum/EIPs#8969
Instead of
Eip7702CodeLoad
code reading methods now returnStateLoad
and only account for cost of loading the target account