chore: bump alloy-eip7702 #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rakita tests are failing on release/v47 branch even before my commits, so I guess this is fine? |
Let me check what is going on, I didn't check it previously as it was just a primitive bump. Will minimize this change as this is side branch and alloy-eip7702 dep will be removed in future. |
rakita
approved these changes
Oct 23, 2024
rakita
reviewed
Oct 23, 2024
| @@ -115,9 +115,8 @@ pub fn apply_eip7702_auth_list<SPEC: Spec, EXT, DB: Database>( | |||
| let mut refunded_accounts = 0; | |||
| for authorization in authorization_list.recovered_iter() { | |||
| // 1. Verify the chain id is either 0 or the chain's current ID. | |||
| if !authorization.chain_id() == 0 | |||
There was a problem hiding this comment.
There was a bug here, !chain_Id would be a bitwise operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alloy-eip7702 now has logic for authority recovery implemented as it should happen in EVM https://github.com/alloy-rs/eips/blob/e712799f4318634bc978d0749cfcd59ff9a59459/crates/eip7702/src/auth_list.rs#L234
This PR updates it to latest version and replaces
RecoveredAuthoritytype with one from alloy-eip7702.There's also now no need for authority list validity check as this is done on decoding