revm: Update account storage methods in CacheDB #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this PR does 2 things in
revm::CachDB
:insert_account_storage
so that it doesn't override the underlying account inforeplace_account_storage
to completely replace the account storageFor (1), I don't actually know whether it was intentional to override the account info with the default (empty) value. I don't quite see when this would be useful.
For (2), it would be useful for implementing the
StateOverride
that's in geth, where there is an option to completely override the storage.I added tests for both methods.