Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing kzg_settings if kzg-rs feature enabled #1601

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix: missing kzg_settings if kzg-rs feature enabled #1601

merged 1 commit into from
Jul 10, 2024

Conversation

jtguibas
Copy link
Contributor

@jtguibas jtguibas commented Jul 10, 2024 •
edited
Loading

Makes sure kzg_settings is still in CfgEnv even if the kzg-rs feature is used.

rakita
rakita approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtguibas jtguibas mentioned this pull request Jul 10, 2024
Closed
@rakita rakita merged commit ea51a04 into bluealloy:main Jul 10, 2024
26 checks passed
This was referenced Jul 10, 2024
Closed
Closed
Closed
Closed
Merged
j75689 pushed a commit to j75689/revm that referenced this pull request Aug 1, 2024
@jtguibas @j75689
fix: missing kzg_settings if kzg-rs feature enabled (bluealloy#1601)
c5544b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita rakita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtguibas @rakita