Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EOF): Add target address expansion checks #1570

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Jun 27, 2024

From EOF spec:
No address trimming is performed on the target_address, and if the address has more than 20 bytes the operation halts with an exceptional failure.

Copy link
Contributor

github-actions bot commented Jun 27, 2024

Valgrind Results:

==3943== Cachegrind, a cache and branch-prediction profiler
==3943== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3943== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3943== Command: target/release/snailtracer
==3943== 
--3943-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.798192697s
==3943== 
==3943== I   refs:      427,038,287
==3943== I1  misses:          3,131
==3943== LLi misses:          2,783
==3943== I1  miss rate:        0.00%
==3943== LLi miss rate:        0.00%
==3943== 
==3943== D   refs:      204,076,878  (132,269,062 rd   + 71,807,816 wr)
==3943== D1  misses:        341,605  (    201,658 rd   +    139,947 wr)
==3943== LLd misses:        137,734  (      4,451 rd   +    133,283 wr)
==3943== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==3943== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3943== 
==3943== LL refs:           344,736  (    204,789 rd   +    139,947 wr)
==3943== LL misses:         140,517  (      7,234 rd   +    133,283 wr)
==3943== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit 7d6888b into main Jun 27, 2024
26 checks passed
@rakita rakita deleted the rakita/ext_expansion_address_check branch June 30, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants