-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tweeks for v4.0 revm release #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valgrind Results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of small tweaks:
cfg.optimism
field removed.CfgEnvWithSpecId/EnvWithSpecId
added to help with the transition asspec_id
is removed fromCfgEnv
optimism_default_handler
default feature added that will makeOptimism
a defaultHandler
inEvmBuilder
additionally enabledmainnet()
andreset_handler_with_mainnet()
functions so mainnet can be used with theOptimism
feature and enabledOptimism
feature by default.modify_env
now takesBox<Env>
(previously it was justEnv
)GetInspector
implemented on all Inspector by default. And it loses its lifetime from the trait.Handler
and toEvnWithSpecId
/CfgEnvWithSpecId
so it is easier to integrate new revm.optimism_default_handler
to add optimism handler register by default always. Andnegate_optimism_default_handler
to negate it for when tests are called with--all-features
.EvnWithSpecId
/CfgEnvWithSpecId
toEvnWithHandlerCfg
/CfgEnvWithHandlerCfg