Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Interpreter): Split calls to separate functions #1005

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

rakita
Copy link
Member

@rakita rakita commented Jan 23, 2024

Split calls to separate functions.

Calls are now very rigid and it is hard to add custom calls to create a new frame. This is first step towards introducing Generics on calls (not sure on the final form that would encompass both creates and calls)

Copy link
Contributor

Valgrind Results:

==3859== Cachegrind, a cache and branch-prediction profiler
==3859== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3859== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3859== Command: target/release/snailtracer
==3859== 
--3859-- warning: L3 cache found, using its data for the LL simulation.
Snailtracer Host+Interpreter benchmark (2.1s) ...            not enough samples
==3859== 
==3859== I   refs:      455,349,621
==3859== I1  misses:         16,874
==3859== LLi misses:          2,878
==3859== I1  miss rate:        0.00%
==3859== LLi miss rate:        0.00%
==3859== 
==3859== D   refs:      237,389,058  (160,565,362 rd   + 76,823,696 wr)
==3859== D1  misses:        348,816  (    208,542 rd   +    140,274 wr)
==3859== LLd misses:        137,561  (      4,051 rd   +    133,510 wr)
==3859== D1  miss rate:         0.1% (        0.1%     +        0.2%  )
==3859== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3859== 
==3859== LL refs:           365,690  (    225,416 rd   +    140,274 wr)
==3859== LL misses:         140,439  (      6,929 rd   +    133,510 wr)
==3859== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit 39e98a5 into main Jan 23, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request Jan 23, 2024
@rakita rakita deleted the split_calls branch January 23, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant