Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helper functions that would create JournalInit from JournaledState #1879

Closed
rakita opened this issue Dec 5, 2024 · 0 comments · Fixed by #1961
Closed

Add helper functions that would create JournalInit from JournaledState #1879

rakita opened this issue Dec 5, 2024 · 0 comments · Fixed by #1961
Labels
good first issue Good for newcomers

Comments

@rakita
Copy link
Member

rakita commented Dec 5, 2024

This is needed from foundry. After this #1865 JournaledState now contains the Database generic, and this will make it hard to clone this struct.

  • JournalInit should be JournaledState with EmptyDB that is created from JournaledState with generic DB.
  • And allow initializing JournaledState with JournalInit
@rakita rakita added the good first issue Good for newcomers label Dec 5, 2024
@FredCoen FredCoen mentioned this issue Dec 31, 2024
Merged
rakita pushed a commit that referenced this issue Jan 8, 2025
@FredCoen
chore: Add helper functions for JournalInit #1879 (#1961)
c28ea1b 
* add journalinit type

* replace from into convention with explicit helpers
This was referenced Jan 8, 2025
Closed
Open
This was referenced Feb 4, 2025
Closed
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add helper functions that would create JournalInit from JournaledState #1879 FredCoen/revm
1 participant
@rakita