Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ recipe.yml ] Firefox removal: Build failure warning for missing RPMs in upstream image #16

Closed
cig0 opened this issue Mar 2, 2024 · 6 comments

Comments

@cig0
Copy link

cig0 commented Mar 2, 2024

Hi all,

When configuring my recipes to remove Firefox RPMs from the upstream image (in favor of the Flatpak version), the pipeline fails because said packages are missing from the upstream image I switched to (kinoite-main -> bazzite).

The issue is triggered when rpm-ostree uninstall firefox is performed, which will throw an exit code 1, making the pipeline fail.

As previously discussed on Discord:

A proposed solution is to leave a heads-up comment on the Firefox removal section in the recipe template, warning the user the pipeline will fail if Firefox RPMs are missing from the upstream image.

@xynydev
Copy link
Member

xynydev commented Mar 2, 2024

It is also worth discussing whether the firefox removal should be kept in the default recipe. It is an opinionated choice that not everyone might want to make, after all. I agree with doing it, certainly, but having it in the default recipe makes doing it implicit for many users.

@cig0
Copy link
Author

cig0 commented Mar 2, 2024

It is also worth discussing whether the firefox removal should be kept in the default recipe. It is an opinionated choice that not everyone might want to make, after all. I agree with doing it, certainly, but having it in the default recipe makes doing it implicit for many users.

I understand that the idea is to eventually phase out Firefox's RPM-based installation in favor of Flatpak (for Universal Blue images), so maybe this discussion might also involve the rest of the team...

@xynydev
Copy link
Member

xynydev commented Mar 2, 2024

I understand that the idea is to eventually phase out Firefox's RPM-based installation in favor of Flatpak (for Universal Blue images)

This is something that wont happen with ublue unless Fedora does it first, though. Fedora should do it, but that's not up to me.

I'm waiting for some other eyes on this issue, though.

@fiftydinar
Copy link
Collaborator

I would put those in # as an example, but not as a "rule", as it's now.

@xynydev
Copy link
Member

xynydev commented Mar 2, 2024

Could just do that I guess, yeah

@gmpinder
Copy link
Member

gmpinder commented Mar 2, 2024

I agree with this direction.

xynydev added a commit that referenced this issue Mar 9, 2024
* fix(recipe): Uncomment Firefox RPM removal

Firefox RPM removal is an opinionated choice, which should be represented as an example of how to remove RPM package properly, not as a "rule".

Solves:
#16

* fix(recipe): Also exclude Firefox from default-flatpaks & add more detailed RPM removal comment

* fix(recipe): Formatting

* fix: streamline comment on ff removal

---------

Co-authored-by: xyny <[email protected]>
vietchinh pushed a commit to vietchinh/ubluelight that referenced this issue Mar 15, 2024
* fix(recipe): Uncomment Firefox RPM removal

Firefox RPM removal is an opinionated choice, which should be represented as an example of how to remove RPM package properly, not as a "rule".

Solves:
blue-build/template#16

* fix(recipe): Also exclude Firefox from default-flatpaks & add more detailed RPM removal comment

* fix(recipe): Formatting

* fix: streamline comment on ff removal

---------

Co-authored-by: xyny <[email protected]>
(cherry picked from commit 9a88dde5bff60557e183dfaac499222d53c4978e)
davemccrea pushed a commit to davemccrea/davidos that referenced this issue Aug 20, 2024
* fix(recipe): Uncomment Firefox RPM removal

Firefox RPM removal is an opinionated choice, which should be represented as an example of how to remove RPM package properly, not as a "rule".

Solves:
blue-build/template#16

* fix(recipe): Also exclude Firefox from default-flatpaks & add more detailed RPM removal comment

* fix(recipe): Formatting

* fix: streamline comment on ff removal

---------

Co-authored-by: xyny <[email protected]>
Book-reader pushed a commit to Book-reader/immutable-hyprland that referenced this issue Sep 6, 2024
* fix(recipe): Uncomment Firefox RPM removal

Firefox RPM removal is an opinionated choice, which should be represented as an example of how to remove RPM package properly, not as a "rule".

Solves:
blue-build/template#16

* fix(recipe): Also exclude Firefox from default-flatpaks & add more detailed RPM removal comment

* fix(recipe): Formatting

* fix: streamline comment on ff removal

---------

Co-authored-by: xyny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants