chore(default-flatpaks): Add safe-check for FlatHub flatpak IDs #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should avoid issues of users typing ID wrongly, which would fail the whole module on booted system, so nothing would get installed or removed. Only FlatHub repo is supported as it's the most popular flatpak repo & it's easy to implement safe-check for it.
gmpinder
reviewed
Jul 20, 2024
|
So how come only flathub repo is allowed? Is there not an api guarantee for 3rd party flatpak repos? |
Co-authored-by: Gerald Pinder <[email protected]>
Well, this is the only way I thought of verifying flatpak IDs. I am not aware of any standardized way of doing this for all remotes. |
Ok, I'm fine with this. If we could possibly expand on this later that would be great, but I think what you have here is a great start that will help the majority of users |
gmpinder
approved these changes
Jul 20, 2024
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should avoid issues of users typing ID wrongly, which would fail the whole module on booted system, so nothing would get installed or removed.
Only FlatHub repo is supported as it's the most popular flatpak repo & it's easy to implement safe-check for it.