Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch cosign registry from GCR to GHCR #237

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

bobcallaway
Copy link
Contributor

This changes the Dockerfile to pull the cosign container image from GHCR instead of Google Cloud. This helps the Sigstore team manage their cloud spend (as GHCR is provided for free and Google Cloud Artifact Registry is not).

Note the container hash does not change and images are posted to both locations upon cosign's release process.

@bobcallaway bobcallaway requested a review from gmpinder as a code owner October 6, 2024 12:55
Copy link
Member

@gmpinder gmpinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, this was never intended to use Google Cloud. I think I must have typo'd this and it was just a happy mistake that it worked.

@gmpinder gmpinder changed the title switch cosign registry from GCR to GHCR fix: switch cosign registry from GCR to GHCR Oct 6, 2024
@gmpinder gmpinder merged commit 2aa888d into blue-build:main Oct 6, 2024
@bobcallaway
Copy link
Contributor Author

This was the normal instructions on sigstore.dev - so probably not a mistake on your part. thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants