fix: Allow docker driver to properly use cache #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix involves creating a new function for the BuildDriver trait called build_tag_push. In order to get the proper logic in place to make use of docker buildx, I had to create a separate function that would construct the build command to include all of the tags necessary for pushing. A default implementation of build_tag_push will be used for podman and buildah which was originally from the build command's functions. Now that we have custom logic for docker builds, we can take advantage of using the GitHub cache features without having the --load arg which had a big effect on build times. We can now also use docker for creating local oci-archive tarballs for local rebasing. Making use of the oci-archive will require the user to create a docker-container builder as it is not supported on the standard docker builder.
gmpinder
requested review from
bayou-brogrammer,
xynydev,
fiftydinar and
gerblesh
gmpinder
commented
Mar 18, 2024
|
Ok I think this is ready to be looked at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix involves creating a new function for the
BuildDrivertrait calledbuild_tag_push. In order to get the proper logic in place to make use ofdocker buildx, I had to create a separate function that would construct the build command to include all of the tags necessary for pushing. A default implementation ofbuild_tag_pushwill be used forpodmanandbuildahwhich was originally from the build command's functions. Now that we have custom logic for docker builds, we can take advantage of using the GitHub cache features without having the--loadarg which had a big negative effect on build times. We can now also use docker for creating localoci-archivetarballs for local rebasing. Making use of theoci-archivewill require the user to create adocker-containerbuilder as it is not supported on the standarddockerbuilder.https://docs.docker.com/build/exporters/oci-docker/