Skip to content

Commit

Permalink
fix: Fix docker login for oauth logins
Browse files Browse the repository at this point in the history
  • Loading branch information
gmpinder committed Sep 11, 2024
1 parent 4634f40 commit 24a9279
Show file tree
Hide file tree
Showing 5 changed files with 83 additions and 4 deletions.
73 changes: 73 additions & 0 deletions .github/workflows/build-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,79 @@ jobs:
grep -q 'ARG IMAGE_REGISTRY=ghcr.io/blue-build' Containerfile || exit 1
bluebuild build --retry-push -S sigstore --push -vv recipes/recipe.yml recipes/recipe-39.yml
docker-build-oauth-login:
timeout-minutes: 60
runs-on: ubuntu-latest
permissions:
contents: read
packages: write
id-token: write
needs:
- build
if: needs.build.outputs.push == 'true'

steps:
- name: Google Auth
id: auth
uses: "google-github-actions/auth@v2"
with:
token_format: "access_token"
service_account: ${{ secrets.SERVICE_ACCOUNT }}
project_id: bluebuild-oidc
create_credentials_file: false
workload_identity_provider: ${{ secrets.WORKLOAD_IDENTITY }}

- name: Maximize build space
uses: ublue-os/remove-unwanted-software@v6

- uses: sigstore/[email protected]

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
with:
install: true

- uses: actions-rust-lang/setup-rust-toolchain@v1

- name: Docker Auth
id: docker-auth
uses: "docker/login-action@v3"
with:
username: "oauth2accesstoken"
password: "${{ steps.auth.outputs.access_token }}"
registry: us-east1-docker.pkg.dev

- uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{github.event.pull_request.head.ref}}
repository: ${{github.event.pull_request.head.repo.full_name}}

- name: Install bluebuild
run: |
cargo install --path . --debug --all-features
- name: Expose GitHub Runtime
uses: crazy-max/ghaction-github-runtime@v3

- name: Run Build
env:
GH_PR_EVENT_NUMBER: ${{ github.event.number }}
COSIGN_PRIVATE_KEY: ${{ secrets.TEST_SIGNING_SECRET }}
BB_BUILDKIT_CACHE_GHA: true
run: |
cd integration-tests/test-repo
bluebuild template -vv | tee Containerfile
grep -q 'ARG IMAGE_REGISTRY=ghcr.io/blue-build' Containerfile || exit 1
bluebuild build \
--registry us-east1-docker.pkg.dev \
--registry-namespace bluebuild-oidc/bluebuild \
--retry-push \
-S sigstore \
--push \
-vv \
recipes/recipe.yml recipes/recipe-39.yml
podman-build:
timeout-minutes: 60
runs-on: ubuntu-latest
Expand Down
3 changes: 2 additions & 1 deletion process/drivers/cosign_driver.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ use std::{fmt::Debug, fs, io::Write, path::Path, process::Stdio};

use blue_build_utils::{
cmd,
constants::{COSIGN_PASSWORD, COSIGN_PUB_PATH, COSIGN_YES},
constants::{COSIGN_PASSWORD, COSIGN_PUB_PATH, COSIGN_YES, DOCKER_CONTENT_TRUST},
credentials::Credentials,
};
use log::{debug, trace};
Expand Down Expand Up @@ -92,6 +92,7 @@ impl SigningDriver for CosignDriver {
username,
"--password-stdin",
registry,
DOCKER_CONTENT_TRUST => "false",
stdin = Stdio::piped(),
stdout = Stdio::piped(),
stderr = Stdio::piped(),
Expand Down
5 changes: 4 additions & 1 deletion process/drivers/docker_driver.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ use std::{

use blue_build_utils::{
cmd,
constants::{BB_BUILDKIT_CACHE_GHA, CONTAINER_FILE, DOCKER_HOST, SKOPEO_IMAGE},
constants::{
BB_BUILDKIT_CACHE_GHA, CONTAINER_FILE, DOCKER_CONTENT_TRUST, DOCKER_HOST, SKOPEO_IMAGE,
},
credentials::Credentials,
string_vec,
};
Expand Down Expand Up @@ -191,6 +193,7 @@ impl BuildDriver for DockerDriver {
username,
"--password-stdin",
registry,
DOCKER_CONTENT_TRUST => "false",
stdin = Stdio::piped(),
stdout = Stdio::piped(),
stderr = Stdio::piped(),
Expand Down
2 changes: 2 additions & 0 deletions utils/src/constants.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ pub const BB_USERNAME: &str = "BB_USERNAME";

// Docker vars
pub const DOCKER_HOST: &str = "DOCKER_HOST";
pub const DOCKER_CONTENT_TRUST: &str = "DOCKER_CONTENT_TRUST";
pub const OAUTH_TOKEN_USER: &str = "oauth2accesstoken";

// Cosign vars
pub const COSIGN_PASSWORD: &str = "COSIGN_PASSWORD";
Expand Down
4 changes: 2 additions & 2 deletions utils/src/credentials.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use typed_builder::TypedBuilder;
use crate::{
constants::{
BB_PASSWORD, BB_REGISTRY, BB_USERNAME, CI_REGISTRY, CI_REGISTRY_PASSWORD, CI_REGISTRY_USER,
GITHUB_ACTIONS, GITHUB_ACTOR, GITHUB_TOKEN,
GITHUB_ACTIONS, GITHUB_ACTOR, GITHUB_TOKEN, OAUTH_TOKEN_USER,
},
string,
};
Expand Down Expand Up @@ -75,7 +75,7 @@ static ENV_CREDENTIALS: LazyLock<Option<Credentials>> = LazyLock::new(|| {
(Some(username), _, _, _, _) if !username.is_empty() => username,
(_, _, _, Some(DockerCredential::UsernamePassword(username, _)), _)
| (_, _, _, _, Some(DockerCredential::UsernamePassword(username, _)))
if !username.is_empty() =>
if !username.is_empty() && username != OAUTH_TOKEN_USER =>
{
username.clone()
}
Expand Down

0 comments on commit 24a9279

Please sign in to comment.