Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include unfinished locales in QA builds #3130

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

nexpid
Copy link
Contributor

@nexpid nexpid commented Oct 12, 2024

If this is intentional — why is it commented out?

Copy link
Contributor

@axellse axellse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locale.cs defines which languages to include, it along with danish is likely commented out due to not being fully translated during the last bloxstrap release

@nexpid
Copy link
Contributor Author

nexpid commented Oct 12, 2024

Locale.cs defines which languages to include, it along with danish is likely commented out due to not being fully translated during the last bloxstrap release

Since it'll only be shown in QA builds, I'd say it's okay to uncomment atm?

@nexpid nexpid changed the title fix: uncomment czechia from Locale.cs fix: include unfinished locales in QA builds Oct 12, 2024
@pizzaboxer
Copy link
Contributor

dude i literally just explained this to you

image

it'll be updated before release

@pizzaboxer pizzaboxer closed this Oct 12, 2024
@pizzaboxer
Copy link
Contributor

pizzaboxer commented Oct 12, 2024

oh wait what i didn't realize they were actually still commented out (since i later changed commented out locales to only show on qa builds instead) okay that's my bad

@pizzaboxer pizzaboxer reopened this Oct 12, 2024
@pizzaboxer pizzaboxer merged commit 2bc46cb into bloxstraplabs:main Oct 12, 2024
2 checks passed
@nexpid nexpid deleted the fix/uncomment-czechia branch October 12, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants