Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option to PartSubtype #224

Closed
wants to merge 3 commits into from

Conversation

linuxgurugamer
Copy link
Contributor

I added a new option: allowSwitchFromInFlight (defaults to true). This is intended to allow a tank to be able to have different types in the editor, but once in flight, to not allow a tank which contains a toxic material (or something incompatible with other tyupes) to be switched in flight

I need this for my life support mod, IFI, have a new tank which can contains two different types of O2 (switchable in flight) and two other toxic materials, which I don't want switchable in flight

My alternative would be to duplicate the parts, I'm trying to minimize the part count.

@blowfishpro
Copy link
Owner

Okay so just to clarify the idea would be that if this subtype is selected, you can't switch off of it once in the flight scene?

@blowfishpro
Copy link
Owner

Also any chance you could change the merge into a rebase? I'd like to keep the commit history clean. If not I can probably figure out how.

@linuxgurugamer
Copy link
Contributor Author

I've never done that, would be nervous to try on someone else's mod
I'd suggest reading this, might be helpful, I don't have a lot of time right now to test this:

https://www.atlassian.com/git/tutorials/merging-vs-rebasing

@linuxgurugamer
Copy link
Contributor Author

Okay so just to clarify the idea would be that if this subtype is selected, you can't switch off of it once in the flight scene?

yes

@leonardfactory
Copy link
Contributor

Just to share, this should be available directly in the GitHub web UI as "Rebase and merge" option in the Merge dropdown button.

github-rebase

blowfishpro pushed a commit that referenced this pull request Mar 4, 2022
Add new option to PartSubtype
blowfishpro added a commit that referenced this pull request Mar 4, 2022
Add allowSwitchFromInFlight on part subtypes
@blowfishpro
Copy link
Owner

I wanted to keep the merge commit on master which unfortunately that option doesn't allow. I merged manually but this is done.

@blowfishpro blowfishpro closed this Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants