Jonathan Gistand - Responsive-Web-Design-II #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolax
reviewed
Jan 10, 2019
| align-content: column; | ||
| margin: 0 auto; | ||
| padding: 2% 0%; |
There was a problem hiding this comment.
Try to avoid using percentages for vertical (top & bottom) padding or margins because screen size is generally dictated by its width
| padding-top: 12px; | ||
| margin: 4rem; | ||
| padding-right: 750px; |
There was a problem hiding this comment.
On the converse, try to use percentages for left-right padding/margins so that they scale with screen size :)
|
|
||
| .footer { | ||
| display: flex; |
There was a problem hiding this comment.
It's a technical necessity and in this case it's a small difference, but I encourage you to try to use consistent spacing to make your code easier for you and others to read.
| /* Mobile Specs */ | ||
|
|
||
| @media (max-width: 500px) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.