[iceberg-extra-props] Merge with latest master #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes rowCount final instead of a volatile AtomicLong, and avoids repeated atomic updates inside of the SpoolingExchangeOutputBuffer in favor of a single final update outside of the loop.
When product tests fail, they produce an report, which is used to generate GitHub Actions annotations so it's easier to know the failure cause, without having to browse the failed job logs. Generate a similar annotation when the test environment fails to start, which is a common failure cause. The original error is still produced, so it can be looked up in logs, for anyone that's used to doing it.
This reverts commit 4f1fa43.
Cleanup after test.
ClickHouse collation is case-sensitive. ClickHouse has same sort ordering as Trino. Per https://clickhouse.com/docs/en/sql-reference/statements/show#show_columns ClickHouse has no per-column collations Clickhouse is UTF-8 encoded with byte-by-byte comparison. https://clickhouse.com/docs/en/sql-reference/statements/select/order-by#collation-support So exactly as trino. https://github.com/airlift/slice/blob/2.2/src/main/java/io/airlift/slice/Slice.java#L1205 That’s why all operations on varchars may pushdown.
It doesn't improve performance much
Add a test to check whether compressed streams are closed properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.