Skip to content

Commit

Permalink
Remove deprecated Alluxio metastore
Browse files Browse the repository at this point in the history
  • Loading branch information
apc999 authored and mosabua committed Jul 14, 2023
1 parent 7611313 commit 59d4859
Show file tree
Hide file tree
Showing 22 changed files with 2 additions and 2,003 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -381,10 +381,6 @@ jobs:
source plugin/trino-hive-hadoop2/conf/hive-tests-${{ matrix.config }}.sh &&
plugin/trino-hive-hadoop2/bin/run_hive_adl_tests.sh
fi
- name: Run Hive Alluxio Tests
run: |
source plugin/trino-hive-hadoop2/conf/hive-tests-${{ matrix.config }}.sh &&
plugin/trino-hive-hadoop2/bin/run_hive_alluxio_tests.sh
- name: Upload test results
uses: actions/upload-artifact@v3
# Upload all test reports only on failure, because the artifacts are large
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,29 +106,6 @@ public void testGlueMetastore()
.hasMessageContaining("Error: Configuration property 'hive.metastore.uri' was not used");
}

/**
* Verify the Alluxio metastore is not supported for Delta. Delta connector extends Hive connector and Hive connector supports Alluxio metastore.
* We explicitly disallow Alluxio metastore use with Delta.
*/
@Test
public void testAlluxioMetastore()
{
ConnectorFactory factory = getConnectorFactory();
assertThatThrownBy(() -> factory.create(
"test",
ImmutableMap.of("hive.metastore", "alluxio"),
new TestingConnectorContext()))
.hasMessageMatching("(?s)Unable to create injector, see the following errors:.*" +
"Explicit bindings are required and HiveMetastoreFactory .* is not explicitly bound.*");

assertThatThrownBy(() -> factory.create(
"test",
ImmutableMap.of("hive.metastore", "alluxio-deprecated"),
new TestingConnectorContext()))
.hasMessageMatching("(?s)Unable to create injector, see the following errors:.*" +
"Explicit bindings are required and HiveMetastoreFactory .* is not explicitly bound.*");
}

@Test
public void testNoCaching()
{
Expand Down
70 changes: 0 additions & 70 deletions plugin/trino-hive-hadoop2/bin/run_hive_alluxio_tests.sh

This file was deleted.

37 changes: 0 additions & 37 deletions plugin/trino-hive-hadoop2/conf/alluxio-docker.yml

This file was deleted.

17 changes: 0 additions & 17 deletions plugin/trino-hive-hadoop2/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,6 @@
<configuration>
<excludes>
<exclude>**/TestHive.java</exclude>
<exclude>**/TestHiveAlluxioMetastore.java</exclude>
<exclude>**/TestHiveThriftMetastoreWithS3.java</exclude>
<exclude>**/TestHiveFileSystemS3.java</exclude>
<exclude>**/TestHiveFileSystemS3SelectPushdown.java</exclude>
Expand Down Expand Up @@ -347,21 +346,5 @@
</plugins>
</build>
</profile>
<profile>
<id>test-hive-hadoop2-alluxio</id>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<includes>
<include>**/TestHiveAlluxioMetastore.java</include>
</includes>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>
</project>
Loading

0 comments on commit 59d4859

Please sign in to comment.