Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reverse-conn / tranlog #4858

Open
wants to merge 1 commit into
base: 8.0
Choose a base branch
from

Conversation

markhannum
Copy link
Contributor

@markhannum markhannum commented Nov 22, 2024

Fixes the reverse-connection early timeout issue that caused the excess recovery bug. Additionally fixes the null-generation bug in the travelog table.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/560 tests failed ⚠.

The first 10 failing tests are:
replay_history [setup failure]
fdb_push_redirect_generated [setup failure]
blob2 [setup failure]
sc_resume2
phys_rep_tiered_nosource_generated
truncatesc_offline_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 3/560 tests failed ⚠.

The first 10 failing tests are:
sicomplex2 [setup failure]
nogen_full_recovery_disable_generated
truncatesc_offline_generated

@markhannum markhannum changed the title Fix reverse-conn / tranlog / skip-recovery Fix reverse-conn / tranlog Nov 22, 2024
@markhannum markhannum force-pushed the physrep_recovery_80 branch 5 times, most recently from 0386537 to 5dce108 Compare November 22, 2024 20:56
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

@markhannum markhannum force-pushed the physrep_recovery_80 branch 2 times, most recently from b92c27b to f0b4e1e Compare November 29, 2024 18:02
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

Compare performance in phys-rep-perf
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 5/563 tests failed ⚠.

The first 10 failing tests are:
vutf8_rowlocks [setup failure]
sc_transactional_rowlocks_generated
phys_rep_perf
phys_rep_via_comdb2_files_generated
truncatesc_offline_generated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants