feat: frontend for allowing marking status for application flagged sets

[emilyjablonski]

Pull Request Template

Issue Overview

This PR addresses #2832

• This change addresses the issue in full
• This change addresses only certain aspects of the issue
• This change is a dependency for another issue
• This change has a dependency from another issue

Description

Sets up being able to mark individual applications in a flagged set as resolved.

Offline design changes:
On the individual flag set page, the id is a pinned left column, and the status is a pinned right column.

How Can This Be Tested/Reviewed?

Check out the issue and the designs.

Visit a closed listing. Go to the applications tab and then the pending review tab. Click into an application flagged set. This page and the resolved page are the two main pieces of the ticket.

On the pending page:

• All applications should have a default status of pending.
• You can select any number of applications and when you hit the save button. If you save as "pending", the set stays as pending and the selected applications move to valid (pending). If you save as resolved the set moves to resolved and the selected applications move to valid and the unselected applications move to duplicate.
• When you move a set from pending to resolved, it should appear in the appropriate side nav tab.
• The leftmost and rightmost columns should be pinned
• Check out mobile on the set page (it was lots of tinkering to get the side nav to be accessible, recognizing the pinned columns makes the table challenging, but living with that for now)

Checklist:

• My code follows the style guidelines of this project
• I have added QA notes to the issue with applicable URLs
• I have performed a self-review of my own code
• I have reviewed the changes in a desktop view
• I have reviewed the changes in a mobile view
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have assigned reviewers
• I have run yarn generate:client and/or created a migration if I made backend changes that require them
• I have exported any new pieces added to ui-components
• My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
• Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

• Read and understand the issue, and ensure the author has added QA notes
• Review the code itself from a style point of view
• Pull the changes down locally and test that the acceptance criteria is met
• Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
• Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

[ColinBuyck]

@emilyjablonski I'm noticing a few things:

1. When updating a duplicate group to resolved, I am not seeing the alert that the Figma shows in screenshot below.

2. The duplicate group table seems to be cutting off on the corners and bottom a bit compared to the rounded edge of the design (also depicted in screenshot above).

PR:

3. A small thing, but I noticed a strange behavior with the side-scroll below where the section can only be dragged immediately after a user scrolls the section with their mouse.

Screen.Recording.2022-09-22.at.4.02.44.PM.mov

[ludtkemorgan]

This is causing a bug. when you "post results".
Steps to reproduce:

1. Select a listing and manually close it.
2. Click "Edit" on that property and click "Post Results".
3. After saving the PDF the property is now listed as "open".

I'm wondering if it was the intention of this change that on save of a listing that was manually closed before the application due date we would automatically open it back up

[emilyjablonski]

@YazeedLoonat do you have context here?

[YazeedLoonat]

@emilyjablonski @ludtkemorgan so this change came into existence because of the issue where if a listing should have been closed (when looking at the application due date the listings weren't actually getting flagged as closed

since that issue isn't directly tied to duplicates I'd feel comfortable walking these changes back and then looking to resolve that in a stand alone issue

@seanmalbert thoughts?

[seanmalbert]

Yes, we can just pull out those changes. I can do that while looking at the migration issue @ludtkemorgan noted below.

[seanmalbert]

This has been pulled out.

[emilyjablonski]

@ColinBuyck Thanks for the review Colin!
(1) The alert piece is a separate ticket, here's the PR for that one
(2) I fixed the bottom issue, but the top one is existing and would love to separate that out since it didn't seem like an easy fix 😢
(3) This is also existing, I rolled (2) and this one into this ticket just for the sake of time if that's okay!

[ColinBuyck]

@emilyjablonski All of that makes sense, and the PR looks great! Other than the bug @ludtkemorgan described, I couldn't find anything else 🥳

[ludtkemorgan]

@seanmalbert @YazeedLoonat I uploaded a downloaded copy of prod locally and get an error when trying to run the migrations. Is this something we should be concerned by?

query failed:
        UPDATE application_flagged_set
        SET rule_key = $1
        WHERE id = $2 -- PARAMETERS: ["undefined-email-undefined","279a4c00-7d9e-4035-b162-470bd70ae2ad"]
error: error: duplicate key value violates unique constraint "UQ_2983d3205a16bfae28323d021ea"

[seanmalbert]

@seanmalbert @YazeedLoonat I uploaded a downloaded copy of prod locally and get an error when trying to run the migrations. Is this something we should be concerned by?

query failed:
        UPDATE application_flagged_set
        SET rule_key = $1
        WHERE id = $2 -- PARAMETERS: ["undefined-email-undefined","279a4c00-7d9e-4035-b162-470bd70ae2ad"]
error: error: duplicate key value violates unique constraint "UQ_2983d3205a16bfae28323d021ea"

@ludtkemorgan ,
The migration file has been updated. There were two issues, typos which caused the undefined parts and fixing that revealed that it wasn't properly accommodating applications belonging to the same set.

I also removed a now unnecessary call to fetch the flagged sets from sites/partners/pages/listings/[id]/index.tsx

[emilyjablonski]

Persistent alert piece merged in 👍

[ludtkemorgan]

I tested this with prod data and it looks good. Thanks for making those changes!