Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update textarea character limits #1906

Merged
merged 6 commits into from
Oct 6, 2021

Conversation

dominikx96
Copy link
Collaborator

Pull Request Template

Issue

Addresses #1890

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Updates character limit in textarea fields.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Try to input more than 1000 characters into the changed fields. A text should be limited to 1000.

  • Desktop View
  • Mobile View
  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes
  • I have run yarn generate:client if I made backend changes

@dominikx96 dominikx96 requested a review from slowbot September 30, 2021 08:57
@dominikx96 dominikx96 self-assigned this Sep 30, 2021
@netlify
Copy link

netlify bot commented Sep 30, 2021

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: 1d34ac7

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/615c01a3b3f9fd000746aa03

😎 Browse the preview: https://deploy-preview-1906--dev-bloom.netlify.app

@netlify
Copy link

netlify bot commented Sep 30, 2021

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: 1d34ac7

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/615c01a3a560340008738363

😎 Browse the preview: https://deploy-preview-1906--dev-partners-bloom.netlify.app

@netlify
Copy link

netlify bot commented Sep 30, 2021

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: 1d34ac7

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/615c01a38fcf990008fca701

😎 Browse the preview: https://deploy-preview-1906--dev-storybook-bloom.netlify.app

@emilyjablonski
Copy link
Collaborator

Looks like the issue is hoping for the new default set within the Textarea component to be 1000

@jaredcwhite
Copy link
Collaborator

jaredcwhite commented Oct 2, 2021

Looks like the issue is hoping for the new default set within the Textarea component to be 1000

@emilyjablonski Do we know where else the textarea component might be used? (also SF, Detroit, etc.). Just wondering, since changing the component default could be considered a breaking change. cc @dominikx96

@emilyjablonski
Copy link
Collaborator

emilyjablonski commented Oct 3, 2021

@jaredcwhite It would be a breaking change which I think is okay if it's the PM request since it's still overwriteable and it would be in the changelog

@dominikx96
Copy link
Collaborator Author

Thanks all! I also updated defaults :)

Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default looks good! Two comments, since the default is 1000 now we don't need to set it on the components where it is 1000, and there were some components using the 150 default which will now need 150 explicitly set. I'm only seeing those ones in Listings Management on a few of the pages.

@dominikx96 dominikx96 merged commit 96d362f into dev Oct 6, 2021
seanmalbert pushed a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
* refactor: Update textarea character limits

* docs: Update changelog

* refactor: Set textarea component default limit to 1000

BREAKING CHANGE: Default limit is 1000 now

Closes bloom-housing#1890

* refactor: Update textarea limits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants