-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update textarea character limits #1906
Conversation
✔️ Deploy Preview for dev-bloom ready! 🔨 Explore the source changes: 1d34ac7 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/615c01a3b3f9fd000746aa03 😎 Browse the preview: https://deploy-preview-1906--dev-bloom.netlify.app |
✔️ Deploy Preview for dev-partners-bloom ready! 🔨 Explore the source changes: 1d34ac7 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/615c01a3a560340008738363 😎 Browse the preview: https://deploy-preview-1906--dev-partners-bloom.netlify.app |
✔️ Deploy Preview for dev-storybook-bloom ready! 🔨 Explore the source changes: 1d34ac7 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/615c01a38fcf990008fca701 😎 Browse the preview: https://deploy-preview-1906--dev-storybook-bloom.netlify.app |
Looks like the issue is hoping for the new default set within the Textarea component to be 1000 |
@emilyjablonski Do we know where else the textarea component might be used? (also SF, Detroit, etc.). Just wondering, since changing the component default could be considered a breaking change. cc @dominikx96 |
@jaredcwhite It would be a breaking change which I think is okay if it's the PM request since it's still overwriteable and it would be in the changelog |
BREAKING CHANGE: Default limit is 1000 now Closes #1890
Thanks all! I also updated defaults :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default looks good! Two comments, since the default is 1000 now we don't need to set it on the components where it is 1000, and there were some components using the 150 default which will now need 150 explicitly set. I'm only seeing those ones in Listings Management on a few of the pages.
* refactor: Update textarea character limits * docs: Update changelog * refactor: Set textarea component default limit to 1000 BREAKING CHANGE: Default limit is 1000 now Closes bloom-housing#1890 * refactor: Update textarea limits
Pull Request Template
Issue
Addresses #1890
Description
Updates character limit in textarea fields.
Type of change
How Can This Be Tested/Reviewed?
Try to input more than 1000 characters into the changed fields. A text should be limited to 1000.
Checklist:
yarn generate:client
if I made backend changes