-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show confirmation modal when publishing listings #1847
Conversation
✔️ Deploy Preview for dev-partners-bloom ready! 🔨 Explore the source changes: 506ab96 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/6143be38af57be0007331798 😎 Browse the preview: https://deploy-preview-1847--dev-partners-bloom.netlify.app |
✔️ Deploy Preview for dev-bloom ready! 🔨 Explore the source changes: 506ab96 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/6143be3821202d00073e087d 😎 Browse the preview: https://deploy-preview-1847--dev-bloom.netlify.app |
✔️ Deploy Preview for dev-storybook-bloom ready! 🔨 Explore the source changes: 506ab96 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/6143be385f9207000786376c 😎 Browse the preview: https://deploy-preview-1847--dev-storybook-bloom.netlify.app |
@@ -21,6 +21,7 @@ type AsideProps = { | |||
setStatus?: (status: ListingStatus) => void | |||
showCloseListingModal?: () => void | |||
showLotteryResultsDrawer?: () => void | |||
showPublishModal?: () => void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a little weird to me to add a LM-specific prop to a component used in other places outside of LM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I follow…this component is used just for the view/edit pages for Listings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's my b! I saw <aside>
but this is <Aside>
…#1847) * feat: Show confirmation modal when publishing listings issue bloom-housing#1772 * Update changelog with bloom-housing#1772
Issue
Addresses #1772
Description
When clicking the Publish button on a listing, it will show a confirmation prompt before saving the new
active
listing status.Type of change
How Can This Be Tested/Reviewed?
Ensure the modal is displayed when attempting to publish a listing.
Checklist:
yarn generate:client
if I made backend changes