Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show confirmation modal when publishing listings #1847

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

jaredcwhite
Copy link
Collaborator

@jaredcwhite jaredcwhite commented Sep 16, 2021

Issue

Addresses #1772

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

When clicking the Publish button on a listing, it will show a confirmation prompt before saving the new active listing status.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Ensure the modal is displayed when attempting to publish a listing.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes
  • I have run yarn generate:client if I made backend changes

@netlify
Copy link

netlify bot commented Sep 16, 2021

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: 506ab96

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/6143be38af57be0007331798

😎 Browse the preview: https://deploy-preview-1847--dev-partners-bloom.netlify.app

@netlify
Copy link

netlify bot commented Sep 16, 2021

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: 506ab96

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/6143be3821202d00073e087d

😎 Browse the preview: https://deploy-preview-1847--dev-bloom.netlify.app

@netlify
Copy link

netlify bot commented Sep 16, 2021

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: 506ab96

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/6143be385f9207000786376c

😎 Browse the preview: https://deploy-preview-1847--dev-storybook-bloom.netlify.app

@@ -21,6 +21,7 @@ type AsideProps = {
setStatus?: (status: ListingStatus) => void
showCloseListingModal?: () => void
showLotteryResultsDrawer?: () => void
showPublishModal?: () => void
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a little weird to me to add a LM-specific prop to a component used in other places outside of LM

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I follow…this component is used just for the view/edit pages for Listings.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my b! I saw <aside> but this is <Aside>

@seanmalbert seanmalbert merged commit 2de8062 into dev Sep 22, 2021
seanmalbert pushed a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
…#1847)

* feat: Show confirmation modal when publishing listings

issue bloom-housing#1772

* Update changelog with bloom-housing#1772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants