Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listings Mgmt: Add confirm to publish #1772

Closed
kathyccheng opened this issue Aug 27, 2021 · 8 comments
Closed

Listings Mgmt: Add confirm to publish #1772

kathyccheng opened this issue Aug 27, 2021 · 8 comments
Assignees
@emilyjablonski
Labels
ready for qa Ready to be QA’d

Comments

@kathyccheng
Copy link
Collaborator

kathyccheng commented Aug 27, 2021 •
edited by slowbot
Loading

When I click on the Publish button,
Add a are you sure? Publishing will push the listing live on the public site

https://www.figma.com/file/Y8bFd0aSz7eYJ2TCNid6s3/bloom-partners?node-id=4477%3A185773

image
@kathyccheng
Copy link
Collaborator Author

@slowbot can you add some details here?

jaredcwhite added a commit that referenced this issue Sep 16, 2021
@jaredcwhite
feat: Show confirmation modal when publishing listings
2e1e40c 
issue #1772
@jaredcwhite jaredcwhite mentioned this issue Sep 16, 2021
Merged
24 tasks
jaredcwhite added a commit that referenced this issue Sep 16, 2021
@jaredcwhite
Update changelog with #1772
506ab96
seanmalbert pushed a commit that referenced this issue Sep 22, 2021
@jaredcwhite
feat: Show confirmation modal when publishing listings (#1847)
2de8062 
* feat: Show confirmation modal when publishing listings

issue #1772

* Update changelog with #1772
@seanmalbert
Copy link
Collaborator

To QA on https://dev-partners-bloom.netlify.app/, edit/create a new listing and publish it. You should see the confirm modal.

@seanmalbert seanmalbert added the ready for qa Ready to be QA’d label Sep 22, 2021
@slowbot slowbot removed listings mgmt ready for qa Ready to be QA’d labels Sep 23, 2021
@slowbot slowbot closed this as completed Sep 23, 2021
@emilyjablonski
Copy link
Collaborator

emilyjablonski commented Sep 24, 2021 •
edited
Loading

@jaredcwhite @slowbot On dev if I click Publish and then Cancel the app gets stuck in a disabled state and you need to refresh. Additionally if we click Publish without name or jurisdiction, we get an error but the modal opens anyway.

@emilyjablonski emilyjablonski added the failed qa This issue or pull request already exists label Sep 24, 2021
@emilyjablonski
Copy link
Collaborator

Realizing that I'll need to slightly refactor the publish modal toggle to work with validations so I can take these bugs!

@jaredcwhite
Copy link
Collaborator

@emilyjablonski I understand this has been resolved in #1850?

@emilyjablonski
Copy link
Collaborator

Yep, but still in review

@emilyjablonski emilyjablonski added the ready for qa Ready to be QA’d label Oct 6, 2021
@slowbot slowbot removed the failed qa This issue or pull request already exists label Oct 7, 2021
@slowbot
Copy link
Collaborator

slowbot commented Oct 7, 2021 •
edited
Loading

@kathyccheng Did you create a new ticket to change the order so modal only shows after errors are resolved?

@slowbot slowbot closed this as completed Oct 7, 2021
@kathyccheng
Copy link
Collaborator Author

@slowbot not yet but will!

seanmalbert pushed a commit to CityOfDetroit/bloom that referenced this issue Jun 23, 2022
@jaredcwhite
feat: Show confirmation modal when publishing listings (bloom-housing…
df8ba75 
…#1847)

* feat: Show confirmation modal when publishing listings

issue bloom-housing#1772

* Update changelog with bloom-housing#1772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilyjablonski emilyjablonski

Labels
ready for qa Ready to be QA’d
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@slowbot @jaredcwhite @kathyccheng @seanmalbert @emilyjablonski