Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1716/remove business logic from HousingCounselor component #1717

Merged
merged 4 commits into from
Aug 27, 2021

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Aug 24, 2021

Pull Request Template

Issue

Addresses #1716

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Removes business logic from HousingCounselor component. Also completed a TODO listed in the file to add icons and formatting to more closely match the other contact sections we have.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Check out the story (we don't currently have any housing counselors set up locally 🤔 maybe we should? Although the Alameda site doesn't link to the housing counselors page we have but an external page so maybe no one is using this component at the moment)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes

@netlify
Copy link

netlify bot commented Aug 24, 2021

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: 06484c6

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/61295422a9d4ca0008003f61

😎 Browse the preview: https://deploy-preview-1717--dev-bloom.netlify.app

@netlify
Copy link

netlify bot commented Aug 24, 2021

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: 06484c6

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/61295422a8e1870007536abc

😎 Browse the preview: https://deploy-preview-1717--dev-storybook-bloom.netlify.app

@netlify
Copy link

netlify bot commented Aug 24, 2021

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: 06484c6

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/6129542252fc0200081817b5

😎 Browse the preview: https://deploy-preview-1717--dev-partners-bloom.netlify.app

@emilyjablonski emilyjablonski changed the title 1716/remove business logic from HousingCounselor 1716/remove business logic from HousingCounselor component Aug 24, 2021
@emilyjablonski emilyjablonski marked this pull request as ready for review August 24, 2021 17:09
Base automatically changed from dev to master August 25, 2021 17:59
@emilyjablonski emilyjablonski changed the base branch from master to dev August 25, 2021 18:02
Copy link
Collaborator

@seanmalbert seanmalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@netlify
Copy link

netlify bot commented Aug 27, 2021

✔️ Deploy Preview for clever-edison-cd22c1 ready!

🔨 Explore the source changes: 06484c6

🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-edison-cd22c1/deploys/61295422032eb000088defea

😎 Browse the preview: https://deploy-preview-1717--clever-edison-cd22c1.netlify.app

@emilyjablonski emilyjablonski merged commit f62c177 into dev Aug 27, 2021
@emilyjablonski emilyjablonski deleted the 1716/housingcounselor branch August 27, 2021 22:15
seanmalbert pushed a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants