-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1716/remove business logic from HousingCounselor component #1717
Conversation
✔️ Deploy Preview for dev-bloom ready! 🔨 Explore the source changes: 06484c6 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/61295422a9d4ca0008003f61 😎 Browse the preview: https://deploy-preview-1717--dev-bloom.netlify.app |
✔️ Deploy Preview for dev-storybook-bloom ready! 🔨 Explore the source changes: 06484c6 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/61295422a8e1870007536abc 😎 Browse the preview: https://deploy-preview-1717--dev-storybook-bloom.netlify.app |
✔️ Deploy Preview for dev-partners-bloom ready! 🔨 Explore the source changes: 06484c6 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/6129542252fc0200081817b5 😎 Browse the preview: https://deploy-preview-1717--dev-partners-bloom.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
748b8c0
to
4adbf86
Compare
✔️ Deploy Preview for clever-edison-cd22c1 ready! 🔨 Explore the source changes: 06484c6 🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-edison-cd22c1/deploys/61295422032eb000088defea 😎 Browse the preview: https://deploy-preview-1717--clever-edison-cd22c1.netlify.app |
4adbf86
to
06484c6
Compare
Pull Request Template
Issue
Addresses #1716
Description
Removes business logic from HousingCounselor component. Also completed a
TODO
listed in the file to add icons and formatting to more closely match the other contact sections we have.Type of change
How Can This Be Tested/Reviewed?
Check out the story (we don't currently have any housing counselors set up locally 🤔 maybe we should? Although the Alameda site doesn't link to the housing counselors page we have but an external page so maybe no one is using this component at the moment)
Checklist: