Dev - fix for AddNumBedroomsFieldToUnitType1628631437422 #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* User roles for partners * generate migration * update client * update seeds and policy * migrate partners from leasing agent table * change enum name * Remove anonymous role * Update authz.service.ts * fix application view * update changelog * fix backend tests * add test * fix ui tests Co-authored-by: Abbie Farr <[email protected]> Co-authored-by: Abbie Farr <[email protected]>
) * updates for cache revalidation on the frontend * fixes listing bug issue * Updates partner listings columns * updates policy and user perms * skips tests until #1616 is implemented * updates to work with new user roles * remove origin from listing service list args * test update
* Add tabs to the listing form * Fix button positions and ensure tabs always render * Add #1644 to Changelog * fixes warning for ArrowForward props Co-authored-by: seanmalbert <[email protected]>
* Add unit size filter to backend (#368) * initial thoughts * initial bedrooms filter (untested) * Fix code style issues with Prettier * fix typo in 'studio' * remove custom filter handling, switch to bedrooms field on unit table * add additional check for invalid comparisons, outside the filter handler * use unit_type table for bedrooms, add field to unit_type table, remove toLowerCase() from filter name comparisons to allow camelCase filter names * Fix code style issues with Prettier * add bedrooms filter to frontend comparison map * fix comparison type for frontend map * fix test and migration indentation * update changelog * regenerate swagger * fix tests * try to fix more ui tests * try to fix more ui tests * add comment for custom filter handling Co-authored-by: Lint Action <[email protected]> * fix missing bedrooms build error Co-authored-by: Lint Action <[email protected]>
* Initial google translate listing * Translations for arrays * Disable caching for GET listing endpoint * Final tweaks to google translate * Update change log for google translations * Fix code style issues with Prettier * Update CHANGELOG.md * Minor cleanup for Google Translate * Initial google translate listing * Translations for arrays * Disable caching for GET listing endpoint * Final tweaks to google translate * Update change log for google translations * Fix code style issues with Prettier * Update CHANGELOG.md * Minor cleanup for Google Translate * Google translate refactoring * Fix listings service spec * adds custom cache interceptor for language * updates custom cache interceptor * Add missing Headers import for listings controller Co-authored-by: Lint Action <[email protected]> Co-authored-by: seanmalbert <[email protected]>
* Add UnitsSummary to Listing * remove listing service changes * redo migration * monthlyRent as number * fix lint errors
Using the length of the array from seed.ts was causing flakiness if the bloom database was not set up in the testing environment. Co-authored-by: seanmalbert <[email protected]>
* set fallback to true for getStaticPaths so new paths can be added * adds revalidate to staticProps * updates for cache revalidation on the frontend * trigger cleanup * fixes listing bug issue * adds additional checks for unit type and priority * new line * Fix code style issues with Prettier * adds listing view * adds other views * adds unitsAvailable to select * updates to pass view as query param for list and by id * removes comment * Update CHANGELOG.md * updates view test * rename spec and remove log * removes another log * updates partner-role migration * updates partner-role migration * adds --runInBand --detectOpenHandles to backend test * adds view param to applications e2e spec test that fetches listings * updates default view to full and fixes housing-counselors bug * view test update Co-authored-by: Lint Action <[email protected]>
* 1629/fcfs with date * changelog
* 1611/what to expect editable * fixup unit test * changelog
* force quit redis connection on app close * updates for redis config * adds enableShutdownHooks to main app * Update archer-listing.ts
Co-authored-by: seanmalbert <[email protected]>
|
❌ Deploy Preview for dev-bloom failed. 🔨 Explore the source changes: d8589ff 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/611ee3cebf0f4900072843c0 |
|
✔️ Deploy Preview for dev-partners-bloom ready! 🔨 Explore the source changes: d8589ff 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/611ee3ceff511b0008959373 😎 Browse the preview: https://deploy-preview-1697--dev-partners-bloom.netlify.app |
|
✔️ Deploy Preview for dev-storybook-bloom ready! 🔨 Explore the source changes: d8589ff 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/611ee3ce5cebf10007db889f 😎 Browse the preview: https://deploy-preview-1697--dev-storybook-bloom.netlify.app |
seanmalbert
added a commit
to CityOfDetroit/bloom
that referenced
this pull request
Jun 23, 2022
…ng#1697) * 1545/lat-long draggable map (#1577) * 1616/user roles (bloom-housing#1673) from 1628 * User roles for partners * generate migration * update client * update seeds and policy * migrate partners from leasing agent table * change enum name * Remove anonymous role * Update authz.service.ts * fix application view * update changelog * fix backend tests * add test * fix ui tests Co-authored-by: Abbie Farr <[email protected]> Co-authored-by: Abbie Farr <[email protected]> * Fix code style issues with Prettier * 1587/Updates Listing Columns and Perms so Leasing Agents can Edit (#1627) * updates for cache revalidation on the frontend * fixes listing bug issue * Updates partner listings columns * updates policy and user perms * skips tests until #1616 is implemented * updates to work with new user roles * remove origin from listing service list args * test update * Fix code style issues with Prettier * Split Listing form up into two main tabs (#1644) * Add tabs to the listing form * Fix button positions and ensure tabs always render * Add #1644 to Changelog * fixes warning for ArrowForward props Co-authored-by: seanmalbert <[email protected]> * Contribute Feature/Ensure Progress Bar is screen reader friendly (bloom-housing#1674) * Add unit size filter to backend (#1660) * Add unit size filter to backend (#368) * initial thoughts * initial bedrooms filter (untested) * Fix code style issues with Prettier * fix typo in 'studio' * remove custom filter handling, switch to bedrooms field on unit table * add additional check for invalid comparisons, outside the filter handler * use unit_type table for bedrooms, add field to unit_type table, remove toLowerCase() from filter name comparisons to allow camelCase filter names * Fix code style issues with Prettier * add bedrooms filter to frontend comparison map * fix comparison type for frontend map * fix test and migration indentation * update changelog * regenerate swagger * fix tests * try to fix more ui tests * try to fix more ui tests * add comment for custom filter handling Co-authored-by: Lint Action <[email protected]> * fix missing bedrooms build error Co-authored-by: Lint Action <[email protected]> * 1431/google translate (#1590) * Initial google translate listing * Translations for arrays * Disable caching for GET listing endpoint * Final tweaks to google translate * Update change log for google translations * Fix code style issues with Prettier * Update CHANGELOG.md * Minor cleanup for Google Translate * Initial google translate listing * Translations for arrays * Disable caching for GET listing endpoint * Final tweaks to google translate * Update change log for google translations * Fix code style issues with Prettier * Update CHANGELOG.md * Minor cleanup for Google Translate * Google translate refactoring * Fix listings service spec * adds custom cache interceptor for language * updates custom cache interceptor * Add missing Headers import for listings controller Co-authored-by: Lint Action <[email protected]> Co-authored-by: seanmalbert <[email protected]> * Restructure units summary table (bloom-housing#1670) * Add UnitsSummary to Listing * remove listing service changes * redo migration * monthlyRent as number * fix lint errors * Fix code style issues with Prettier * Hardcode the number of items in listings.e2e-spec.ts. (#1643) Using the length of the array from seed.ts was causing flakiness if the bloom database was not set up in the testing environment. Co-authored-by: seanmalbert <[email protected]> * Contribute/Create listing updated UI component (bloom-housing#1676) * 1621/Listing Views (#1626) * set fallback to true for getStaticPaths so new paths can be added * adds revalidate to staticProps * updates for cache revalidation on the frontend * trigger cleanup * fixes listing bug issue * adds additional checks for unit type and priority * new line * Fix code style issues with Prettier * adds listing view * adds other views * adds unitsAvailable to select * updates to pass view as query param for list and by id * removes comment * Update CHANGELOG.md * updates view test * rename spec and remove log * removes another log * updates partner-role migration * updates partner-role migration * adds --runInBand --detectOpenHandles to backend test * adds view param to applications e2e spec test that fetches listings * updates default view to full and fixes housing-counselors bug * view test update Co-authored-by: Lint Action <[email protected]> * 1629/fcfs with date (bloom-housing#1680) * 1629/fcfs with date * changelog * 1611/what to expect editable in listings management (bloom-housing#1681) * 1611/what to expect editable * fixup unit test * changelog * Make actions an optional prop and hide the footer when not present. (bloom-housing#1690) * Make features section more robust (bloom-housing#1688) * Fixes whatToExpect UI Component failing test (bloom-housing#1692) * force quit redis connection on app close * updates for redis config * adds enableShutdownHooks to main app * Update archer-listing.ts * Add migration (bloom-housing#1689) Co-authored-by: seanmalbert <[email protected]> * Fix code style issues with Prettier * adds SRO to num_bedroom case Co-authored-by: Emily Jablonski <[email protected]> Co-authored-by: Abbie Farr <[email protected]> Co-authored-by: Abbie Farr <[email protected]> Co-authored-by: Lint Action <[email protected]> Co-authored-by: Jared White <[email protected]> Co-authored-by: pfeeny5 <[email protected]> Co-authored-by: Austin Valeske <[email protected]> Co-authored-by: Marcin Jędras <[email protected]> Co-authored-by: Will Lin <[email protected]> Co-authored-by: Anders Schneider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Issue
Addresses # (issue)
Description
Please include a summary of the change and which issue is addressed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
How Can This Be Tested/Reviewed?
Please describe the tests that you ran to verify your changes. Provide instructions so we can review. Please also list any relevant details for your test configuration
Checklist: