Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook styling fixes #1309

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Storybook styling fixes #1309

merged 3 commits into from
Jun 7, 2021

Conversation

jaredcwhite
Copy link
Collaborator

Pull Request Template

Issue

Addresses #1263

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

This PR fixes a display issues with the "Code" samples in Storybook, as well as problem preventing certain components using LinkComponent from displaying the right styles.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Verify in Storybook.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • N/A -I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes

@jaredcwhite jaredcwhite requested a review from slowbot June 2, 2021 22:43
@netlify
Copy link

netlify bot commented Jun 2, 2021

✔️ Deploy Preview for clever-edison-cd22c1 ready!

🔨 Explore the source changes: 9fce64a

🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-edison-cd22c1/deploys/60b8097650460400075b8f8b

😎 Browse the preview: https://deploy-preview-1309--clever-edison-cd22c1.netlify.app

slowbot
slowbot approved these changes Jun 2, 2021
View reviewed changes
Copy link
Collaborator

@slowbot slowbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaredcwhite Adde one small fix to sort language nav which wasn't showing up in the navigation grouping

@jaredcwhite
Copy link
Collaborator Author

@slowbot Hmm, I'm not seeing your commit. Still need to push maybe?

@jaredcwhite
Copy link
Collaborator Author

@slowbot Bump

@akegan akegan mentioned this pull request Jun 7, 2021
Merged
26 tasks
@slowbot
Copy link
Collaborator

slowbot commented Jun 7, 2021

@jaredcwhite Pushed

@jaredcwhite jaredcwhite merged commit fe02006 into master Jun 7, 2021
jaredcwhite added a commit that referenced this pull request Jun 7, 2021
@jaredcwhite
Update Changelog with PR #1309
41072cf
willrlin referenced this pull request in CityOfDetroit/bloom Jun 9, 2021
@jaredcwhite @willrlin
Storybook styling fixes (#1309)
4f186bb 
* Fix docs code samples and link button stories in Storybook

* Imprve LinkComponent default for use in Storybook

* fixing placement of language nav

Co-authored-by: Jesse Arnold <[email protected]>
willrlin referenced this pull request in CityOfDetroit/bloom Jun 9, 2021
@jaredcwhite @willrlin
Update Changelog with PR #1309
aa88386
willrlin referenced this pull request in CityOfDetroit/bloom Jun 9, 2021
@willrlin
Revert "Update Changelog with PR #1309"
95f09bd 
This reverts commit aa88386.
willrlin referenced this pull request in CityOfDetroit/bloom Jun 9, 2021
@willrlin
Revert "Storybook styling fixes (#1309)"
e2cce32 
This reverts commit 4f186bb.
willrlin referenced this pull request in CityOfDetroit/bloom Jun 9, 2021
@willrlin
Revert "Update Changelog with PR #1309"
8a01680 
This reverts commit aa88386.
willrlin referenced this pull request in CityOfDetroit/bloom Jun 9, 2021
@willrlin
Revert "Storybook styling fixes (#1309)"
f052423 
This reverts commit 4f186bb.
@jaredcwhite jaredcwhite mentioned this pull request Jun 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slowbot slowbot slowbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredcwhite @slowbot