Remove the Storyshots functionality from ui-components #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredcwhite
added
dependencies
|
Looks great! It think the only remaining change is removing |
|
@emilyjablonski Done! |
emilyjablonski
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on #1050 by removing Storybook's Storyshots functionality from the test suite. We will still write stories to provide human-centric UI demos in Storybook, but it won't be connected to the test suite.
A worthwhile follow up from this would be to redo some of the stories with knobs and other mechanisms so they work better as visual demos (now that automated testing isn't part of the equation).