Fix how unitsSummarized uses AMI charts

[pbn4]

When changing AMI chart entity to be a relation of Unit instead of Property I noticed that we are actually not using amiChartId per unit when computing this, but we are retrieving an AMI chart for first Unit in a collection and apply that for the rest.

Notes

• Unit summarized logic only used AMI of first unit and used that to compute summary table
• Use range if we have multiple AMI charts

[pbn4]

Related code

bloom/services/listings/src/lib/unit_transformations.ts

Line 43 in 974f5d0

const amiChartId = units[0].amiChartId

[software-project]

For now at least that works as we don't really have multiple charts per listing. If we did there is a matter how would we even show it (just wider income ranges? or something more?). Another question is (I don't remember the answer) if we really need multiple ami charts per one listing. If we will have new property model, maybe one chart per each listing for the property will be enouch?

[pbn4]

If we did there is a matter how would we even show it (just wider income ranges? or something more?).

OK that I don't know and it probably needs to be discussed more broadly.

Another question is (I don't remember the answer) if we really need multiple ami charts per one listing.

@slowbot If I recognize correctly we want to be able to configure ami chart at unit level, right?

[slowbot]

@software-project @pbn4

There are and will be use cases of multiple ami charts per building so we should allow for ami chart to be assigned at the unit level.

[emilyjablonski]

For QA, ensure that existing HMI tables look as we expect them to. Two new seeds with multiple AMI charts have been added but may not be on dev.

[slowbot]

@seanmalbert @emilyjablonski Can you help me get the new multiple AMI charts seeds onto dev so I can QA?

[slowbot]

@emilyjablonski Why is there a range expressed for max income per ami level?

I think we can simplify this table and only display a single max max income for each hh size and ami level.

I assume @pbn4 comment had to do with a table where there was only a single column for multiple AMI charts. Since we have dedicated columns for each chart in this example we don't need a range.

https://dev-bloom.netlify.app/listing/977dad6d-9b7c-4db2-bba5-cb95899599f6/test_default_multiple_ami_and_percentages_548_market_street_san_francisco_ca